Giter Site home page Giter Site logo

Comments (5)

mikepenz avatar mikepenz commented on May 29, 2024

Good day.

Thank you for the ticket.

The proposed way at this time is to apply it to the Android and Desktop modules in your scenario: https://github.com/mikepenz/AboutLibraries/blob/develop/app/build.gradle#L5
And for the Desktop respectively: https://github.com/mikepenz/AboutLibraries/blob/develop/app-desktop/build.gradle.kts#L6

The plugin will transitively collect the dependencies in that case.

from aboutlibraries.

Wavesonics avatar Wavesonics commented on May 29, 2024

Huh, so changing to just applying the plugin to those terminal modules, it doesn't seem to run the task automatically when I build those targets though.

I can run the exportLibraryDefinitions task manually and it produces the json file, but if I just run assemble or run, it doesn't produce the json, and trying to view the libraries in the app crashes (desktop).

from aboutlibraries.

mikepenz avatar mikepenz commented on May 29, 2024

@Wavesonics depends on the configuration. The default configuration would hook up the build as part of the Android builds. However that can be disabled via: https://github.com/mikepenz/AboutLibraries/blob/develop/app/build.gradle#L89

For desktop, it wouldn't be automatically linked, that's correct.
You can see the README for the sample highlighting that you'd execute the task: https://github.com/mikepenz/AboutLibraries/blob/develop/app-desktop/README.md
And how to use it: https://github.com/mikepenz/AboutLibraries/blob/develop/app-desktop/src/main/kotlin/main.kt#L17C1-L17C1

That being said, in general I'd advice to update and check-in the outputs manually for Android too - as it gives more control and change swill show up in the commit history:
https://github.com/mikepenz/AboutLibraries/blob/develop/README.md#enterprise

from aboutlibraries.

Wavesonics avatar Wavesonics commented on May 29, 2024

Okay, ya that works. It would be nice to have an overload for the composable function that just accelts a Libs object, and doesn't worry about constructing it.

That way we could have a single multi-platform composable.

Anyway, thanks for your help!

from aboutlibraries.

mikepenz avatar mikepenz commented on May 29, 2024

@Wavesonics there is the API to pass in just the Libs: https://github.com/mikepenz/AboutLibraries/blob/develop/aboutlibraries-compose/src/commonMain/kotlin/com/mikepenz/aboutlibraries/ui/compose/SharedLibraries.kt#L33-L49 (transformed to StableLibs for performance improvement)

However at the moment this wouldn't include the platform specific dialog handling.

from aboutlibraries.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.