SVInt(T value) constructor fails to compile for char values on aarch64

[pawelmoll]

SVInt(T value) constructor fails to compile for char values on aarch64

[pawelmoll]

If you're just using GitHub Actions than the matter is relatively simple - AArch64 runners "are coming". There's already a trial going on for larger, paying customers (https://github.blog/changelog/2023-10-30-accelerate-your-ci-cd-with-arm-based-hosted-runners-in-github-actions/) so I'd hope it's just matter of time for them to become business as usual. I'll keep you updated.

[yanggeorge]

// SVInt.h or where the error occurs
// The constructor or function where std::bit_width(value) is called
bitWidth = (bitwidth_t)std::bit_width(static_cast<unsigned char>(value));

Explicit Type Casting: Before calling std::bit_width, you should cast the variable value of type char to unsigned char. This casting is safe and doesn't change the binary representation of the data, but ensures that the type matches the expected input for std::bit_width.

[MikePopoloski]

I fixed the build in 3350030 but I have no way to check that the tests actually pass on AArch64 hardware.

[pawelmoll]

Thanks a lot for a very quick turnaround! :-)

The code now builds and tests pass all right:

$ git rev-parse HEAD
de7c88b833ed4af529d2557642374c10bd7205bd
$ uname -m
aarch64
$ ctest --output-on-failure
Test project /home/pawmol01/src/slang/build
    Start 1: unittests
1/6 Test #1: unittests ........................   Passed    0.75 sec
    Start 2: regression_delayed_reg
2/6 Test #2: regression_delayed_reg ...........   Passed    0.01 sec
    Start 3: regression_wire_module
3/6 Test #3: regression_wire_module ...........   Passed    0.01 sec
    Start 4: regression_all_file
4/6 Test #4: regression_all_file ..............   Passed    0.02 sec
    Start 5: netlist_unittests
5/6 Test #5: netlist_unittests ................   Passed    0.02 sec
    Start 6: tidy_unittests
6/6 Test #6: tidy_unittests ...................   Passed    0.02 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) =   0.83 sec
$

Also, let me know if you were willing to consider expanding your test infrastructure to cover AArch64 as well.

[MikePopoloski]

I'm not against expanding testing to cover AArch64, but I don't think GitHub Actions provides such a runner for public repos? I don't have the time or expertise to figure it out and get it set up but if you wanted to contribute something I'd be happy to accept it.