Giter Site home page Giter Site logo

Move into the mikro-orm repo about nestjs HOT 3 CLOSED

mikro-orm avatar mikro-orm commented on September 2, 2024
Move into the mikro-orm repo

from nestjs.

Comments (3)

B4nan avatar B4nan commented on September 2, 2024 1

That is a valid point, but that would be the same for all the other packages in the MikroORM repo. Even though they are probably more often updated than this one, they still get a version bump, even when they have have no changes.

For me its quite different with the packages from monorepo. They form the ORM and are much more tighly coupled. Developing something in one package often involves changes in others.

On the other hand, this is an adapter that ingerating two libraries together and is more of an extension for nest than MikroORM - that is maybe the biggest reason why I dislike it being there.

from nestjs.

B4nan avatar B4nan commented on September 2, 2024

I want to keep it outside, there is no need to sync the version, I see it the opposite way - version bump here has a meaning, there is a change in this package (if we had it in the main one, there would be new versions and pretty much no changes).

I do sync the major versions as those usually require some updates, but I don't see any benefits doing the sync for minor and patch versions.

Also, this package has no direct dependencies, only peers and dev deps. I don't see anything wrong or outdated here, the version of nest or the orm in tests is quite irrelevant (only the major version is). We can set up renovate here as well, if that bothers you (it will be much less time than migrating this into the monorepo anyway).

from nestjs.

Langstra avatar Langstra commented on September 2, 2024

That is a valid point, but that would be the same for all the other packages in the MikroORM repo. Even though they are probably more often updated than this one, they still get a version bump, even when they have have no changes.

I think it would not hurt to keep the dependencies up to date, maybe something seemingly irrelevant breaks the package and in such case we'd like to know.

from nestjs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.