The UseRequestContext make the method return void

[mikro-orm]

The UseRequestContext make the method return void

[B4nan]

I was just about to write the same but realized what the issue is about. The decorator wraps given method but it won't return its return value.

The return value is ignored on this line:

nestjs/src/mikro-orm.common.ts

Line 22 in 4e0bad0

await originalMethod.apply(context, args);

Anyway, next time please share some code when filing a bug report, this is not the right way to do it...

[B4nan]

4.3.1 is out, sry it took so long, i always forget about this package (and always get notifications like this when i am away from laptop) 🤷

[Langstra]

It is unclear what your intentions are exactly. Could you create a repository with a reproduction of the bug? That is much easier to debug then these steps to reproduce.

[SimoneDagna]

The "problem" is also in RequestContext class from Mikro-Orm project:
https://github.com/mikro-orm/mikro-orm/blob/7e7427335a005bb379509a9a9e86a01c44a21e07/packages/core/src/utils/RequestContext.ts#L37-L42

the return type is Promise<void>, so even modifying the line:

nestjs/src/mikro-orm.common.ts

Line 22 in 4e0bad0

await originalMethod.apply(context, args);

the UseRequestContext decorator will be unable to return the original method result.

[jearangoo]

can this fix be included into a new version in npm?

[B4nan]

Oh right, forgot to release it - I don't have time for this right now but will ship it early next week.

But the method is really a simple one, nothing special in it, so you can just copy the code to your project and use your (fixed) implementation instead.

[jearangoo]

no problem, thank you very much @B4nan