Comments (3)
maximecb
commented on August 25, 2024
Please elaborate on your reasoning. Iād like to be kept in the loop a bit more here, considering I might have to maintain this code.
from babyai.
rizar
commented on August 25, 2024
Sure. I feel uneasy about our practice of having GoToObj put GoNextTo on the stack, and then having GoNextTo delete itself from it:
https://github.com/mila-udem/babyai/blob/master/babyai/bot.py#L607
I don't yet full understand how this works so far, but it seems to me that we could refactor this part to have GoToObj.take_action() call GoNextTo.take_action(), in the same way as GoToObj.get_action() calls GoNextTo.get_action().
from babyai.
rizar
commented on August 25, 2024
Fixed by #26
from babyai.
Related Issues (20)
- You cannot pick up or put down objects in manual-mode in enjoy.py HOT 6
- Know full vocabulary apriori. HOT 2
- Impossible missions are sampled? HOT 2
- Question about performance HOT 2
- PutNextLocal HOT 8
- Bot bugs (attribute error: prev_carrying) HOT 2
- Unable to run PPO agent with arch=bow_endpool_res_pixels HOT 2
- What's the package version of gym-minigrid and gym used for the baseline results? HOT 2
- When I run 'BabyAI-PutNext-v0', it did not work after 24 hours' training... HOT 1
- Sampling unsolvable demonstrations
- Mission not accomplished in the last observation
- Error during install: "pip install --editable ." in babyai folder HOT 2
- What does the agent see, in 7x7? -- possible bug in the task? HOT 1
- Get demonstration for 'MiniGrid-MultiRoom-N4-S5-v0' HOT 1
- Headless rendering issue for environments with doors HOT 5
- Missing dependency for scikit-build HOT 4
- AttGRU model is broken + my quick Fix HOT 5
- Visualizing stored "images" HOT 2
- Publish pip package HOT 1
- enjoy.py script seems to expect old PyQT version of gym-minigrid HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from babyai.