Giter Site home page Giter Site logo

Comments (3)

maximecb avatar maximecb commented on August 25, 2024

We should choose whether we do this or not before regenerating all the demos IMO. Once the demos are regenerated and the updated paper is out, it would be best to avoid changing the bot if possible.

from babyai.

rizar avatar rizar commented on August 25, 2024

Yes, I agree that it is time to finalize the ICLR version of the bot. I've tried to quickly make this change to the bot, and I found it not super-easy. Doing this properly requires copying a lot of code from OpenSubgoal to GoNextToSubgoal, the code that is responsible for dropping the key after the door is open and for picking up the object that the agent was carrying when it decided to go for the key. I can imagine another refactoring that makes this behavior more natural to implement, but I am not sure if this suboptimality is so important... what do you think?

from babyai.

maximecb avatar maximecb commented on August 25, 2024

If you can get it working by Jan 31st it could be ok. By then we really need to generate the demos and make sure that the code to run the experiments is still working correctly. Might be wise to start some test runs without waiting for all the demos to be generated.

from babyai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.