Giter Site home page Giter Site logo

Comments (4)

miladrahimi avatar miladrahimi commented on August 26, 2024

Currently, this feature is no available. Could you please explain why do you need this feature and what's your use case?

from phprouter.

lucacastelnuovo avatar lucacastelnuovo commented on August 26, 2024

I'm trying to create ratelimit middleware (https://github.com/Luca-Castelnuovo/CubeQuence-framework/blob/master/src/CubeQuence/Middleware/RateLimit.php). And I would like to be able to have multiple limits set for multiple endpoints.

For the following example:

$router->get('/foo', 'ExampleController@foo', RateLimit::class); // 45 requests / 60 seconds
$router->get('/bar', 'ExampleController@bar', RateLimit::class); // 10 requests / 5 seconds

I was planning to achieve this by getting the request path

$path = $request->getUri();
$path = strtok($path, '?');
$path = strtok($path, '#');

And then lookup aan associative array

$path = Request::path($request);

$this->max_requests = (int) Config::get("ratelimit.{$path}.max_requests") ?: 60;
$this->reset_time = (int) Config::get("ratelimit.{$path}.reset_time") ?: 60;

This would work fine if I didn't use URL params. Because if you use the following:

$router->get('/fooBar/{uuid}', 'ExampleController@foo', RateLimit::class); // 45 requests / 60 seconds

I wouldn't be able to create an config entry for each uuid.
So if I could get the basepath like:

$basePath = Request::basePath($request);

$this->max_requests = (int) Config::get("ratelimit.{$basePath}.max_requests") ?: 60;
$this->reset_time = (int) Config::get("ratelimit.{$basePath}.reset_time") ?: 60;

I could configure limits for each route.

from phprouter.

miladrahimi avatar miladrahimi commented on August 26, 2024

Thanks for your suggestion, I'm working on the next major version of PhpRouter, I will consider this feature.

from phprouter.

miladrahimi avatar miladrahimi commented on August 26, 2024

This feature is added to the last release. Please check:
https://github.com/miladrahimi/phprouter#current-route

from phprouter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.