Valid boolean attributes are stripped

[milesj]

Valid boolean attributes are stripped

[rmccue]

I clarified this one on Twitter:

That's is the right bit of the spec for this: it's present, therefore it's true. The following sentence is essentially an authoring conformance requirement, and doesn't in any way override this.

Therefore, we should set the value to true if it's set at all.

[milesj]

@rmccue I disagree. That may be what the spec says, but I'd wager many developers have passed ="false" or something similar in their HTML. We should probably just remove them if that happens.

[rmccue]

Developers may do that, but it won't work, as browser behaviour matches the spec: https://codepen.io/anon/pen/GPgQNK

Firefox, Chrome, and Safari all treat the presence of a boolean attribute as truthy, even if the value is empty string, "false", "0", etc. Interweave should match this behaviour so that it can match dangerouslySetInnerHTML's behaviour.

[milesj]

Hrmmm, not sure I fully agree with the change though. This would definitely be a breaking change, so I'd wait till my TS PR is done before handling this.

[rmccue]

In the meantime, would you consider merging a change to allow at least empty string to be treated as true? This is breaking our parsing right now.

[milesj]

@rmccue Yeah that'll be fine.