Comments (3)
from cornrow.
Thanks a lot for your feedback. This is very valuable.
I have one request for you. Could you open a regular pull request? This would help setting up a proper review, because i have some remarks :)
Thanks a lot!
-Manuel
from cornrow.
I've compiled cornrow on Docker with an Alpine image, during this I found some issues addressed in the attached patch, also included the dockerfile builder. All tests have been on 0.8.1.
It basically boils down to a few issues
1. Use of "uint" in thirdparty/libcornrow/src/audio/Peq.cpp, assume size_t should be appropriate 2. Use of "uint" throughout cornrowd/src/config/Persistence.cpp, i typedef'ed it to "unsigned int" 3. Alpine uses an external lib for execinfo (not maintained and in disorder) 4. Use of __bswap_16 vs __bswap16 in thirdparty/libcornrow/src/audio/AlsaSink.cpp 5. Unused variable in thirdparty/libcornrow/src/loguru/loguru.cpp(530)
char buff[256] __attribute__((unused));
7. Missing library in thirdparty/qtzeroprops/thirdparty/QtZeroConf/CMakeLists.txt, need avahi-common. This hit me in building (Docker) for debian bullseye as well.
target_link_libraries(QtZeroConf PRIVATE avahi-client) + target_link_libraries(QtZeroConf PRIVATE avahi-common)
And that's about it, very nice and clean code :)
Now, the Alpine execinfo is in disorder and does core dump on calling backtrace.
-Morten
can I ask you to share your docker alpine configuration? I was looking to build that too, did you had success with that? thank you
from cornrow.
Related Issues (20)
- tested on Pi 4 HOT 7
- rpi zero conection issues HOT 4
- signal=SEGV HOT 10
- crashing with "Assertion `error == OMX_ErrorNone' failed." HOT 4
- Snapcast integration - output to ALSA loopback, FIFO, or STDOUT? HOT 6
- Configure Airplay or Bluetooth enabled HOT 1
- Usage of non-SBC codecs HOT 2
- Unmet dependency: libboost-system1.67 on bullseye HOT 2
- Unable to Connect Bluetooth Device On Raspbian Buster and Bullseye HOT 10
- Question: can I use it on OrangePi? HOT 10
- Issues building from source HOT 8
- Unable to reconnect after client "forgets" the server device HOT 1
- No audio in snapcast HOT 3
- unable to start cornrowd.service HOT 8
- terminate called after throwing an instance of 'std::out_of_range' HOT 5
- Problems with sound HOT 2
- Debian bookworm support? HOT 2
- Connection problems with smartphone HOT 5
- can cornrow be containerized? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cornrow.