Giter Site home page Giter Site logo

Comments (1)

mingchuno avatar mingchuno commented on June 11, 2024

You do ask me via email but I will post my reply here so that everyone can see it.

After revising the code. I did not expose all the underlying grpc APIs to the service layer (https://github.com/mingchuno/etcd4s/tree/master/etcd4s-core/src/main/scala/org/etcd4s/rpc)
The underlying PutRequest does have a much richer option to choose from. It is the same for the Watch API. I do wrap the Watch API with akka-stream for easier to use in the first place.
If I did not wrap the Watch API with akka-stream, the signature should be def watch(responseObserver: io.grpc.stub.StreamObserver[WatchResponse]): io.grpc.stub.StreamObserver[WatchRequest]

So for your question, I can redesign the APIs and expose more of the underlying services to lib user...What do you think?

from etcd4s.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.