testing: test.csv2df.reader.open_csv()

[mini-kep]

testing: test.csv2df.reader.open_csv()

[epogrebnyak]

Eventually, the test with https://docs.python.org/3/library/unittest.mock.html#mock-open I did not finish it, it seems the function can digest any kinds of arguments.

The test with temp file in b141b15 is really preferred one: it is quicker to write and easier to maintain, and allows to test for (3) functionality too.

@pytest.fixture    
def temp_path():
    with NamedTemporaryFile() as f:
        abspath = f.name
    p = Path(abspath)    
    p.write_text("abc\n123")
    return p

class Test_open_csv:    

    def test_on_string_argument_raises_TypeError(self):
        path_string = 'abc.csv'
        with pytest.raises(TypeError):
            open_csv(path_string)

    def test_on_Path_runs_with_no_error(self, temp_path):
        assert open_csv(temp_path)

    def test_on_Path_provides_readable_input(self, temp_path):
        with open_csv(temp_path) as f:            
            assert f.readlines() == ['abc\n', '123'] 

[epogrebnyak]

@bakakaldsas, I need you final "yes, sure" kind of approval to close this 👍

[bakakaldsas]

Yes, this is definitelly better.

[bakakaldsas]

So for the sake of cleaner test file the multiple test cases should be removed only leaving the preferred version?

[epogrebnyak]

I think yes, keep just one version, the simplest one. I moved things around in last few commits. 2 сент. 2017 г. 22:37 пользователь "bakakaldsas" <[email protected]> написал: So for the sake of cleaner test file the multiple test cases should be removed only leaving the preferred version? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#91 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI1grj0CHbulQjtJVNZiboRMaaDPMsq1ks5sea5wgaJpZM4PKz0S> .