Giter Site home page Giter Site logo

Comments (5)

jellonek avatar jellonek commented on August 12, 2024

Very good catch and the cause why my branch is failing after rebase :)
For dev purpose will hardcode some values there until You will provide PR with correct resolution.

from virtlet.

vefimova avatar vefimova commented on August 12, 2024

Committed fix is temporary workaround

from virtlet.

vefimova avatar vefimova commented on August 12, 2024

@jellonek @nhlfr

Want to share my considerations re cpu resource management:

So for resource management k8s have

  • optional settings for CFS (Completely Fair Scheduler):
    • quotaPeriod
    • cpuPeriod
      These put limits for i/o bandwidth limits, not cpu resource usage itself.
  • and sharesPerCPU - relative value to set weighted share of available cpu resources for VM
    which is set by default=2 (1 cpu = 1024)

So, then, for example nova has cpu overcommitment ratio set as 16:1 => VMsPerHost = vCPUs*16
But for virtlet wihout setting sharesPerCPU directly it would be as 512:1, which is obviously is not acceptable at all.

There could be added limits per namespace, then default will be set to limit if there is no request for pod, but we can't rely on that. Such low default is probably unexpectable for us, to have the same ratio
we need to have 64. Probably, we need to try to propose having kubelet option for that, WDYT?

So for now I'm going to prepare patch which will set all available vCPUs for each VM with defined CPU Tuning tag with specified shares. As long as nothing is set, cpu time will be, obviously, spreaded equally among VMs, there will be problems if we start to set "requests" for cpu for some of VMs and use defaults for others, and ofcource if we overload the host by amount of created VMs, but for now it's POC, right? :) Do you agree with that?

from virtlet.

jellonek avatar jellonek commented on August 12, 2024

Sorry for not answering earlier - idea looks great and I like your implementation of it :)

from virtlet.

jellonek avatar jellonek commented on August 12, 2024

As it's already merged - closing.

from virtlet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.