Giter Site home page Giter Site logo

Comments (6)

professionalNoob123 avatar professionalNoob123 commented on July 4, 2024 1

Great! Everything works good.

Thank You

from mirotalk.

miroslavpejic85 avatar miroslavpejic85 commented on July 4, 2024

Hello @professionalNoob123,

Expected someone else to become the host when the first person leaves.

The last one that remain in the meeting, become the host.

PS: I don't think giving the roles of host to a random one is the best thing, also because when I leave the room I don't have to worry about it who should I give permission to eject the others and so on. I don't see it as a bug, and I'd rather keep this current logic, what do you think?

Join also with us on forum, where we can also discuss about, channel: ideas-and-suggestions.
Thank you!

from mirotalk.

professionalNoob123 avatar professionalNoob123 commented on July 4, 2024

PS: I don't think giving the roles of host to a random one is the best thing, also because when I leave the room I don't have to worry about it who should I give permission to eject the others and so on. I don't see it as a bug, and I'd rather keep this current logic, what do you think?

Yes, you shouldn't give the role of host to a random one. Though, let's say I'm in a meeting (as host) and connected to 3 other peers, and the room is unlocked (default). Then I disconnect due to internet issues... thus there is no host and the room is unlocked. Which could lead to someone else joins the meeting (ex. peer name: Joe) which may be a security issue because nobody can control him (Joe).

PS: I'm not saying to lock the meeting as default

from mirotalk.

miroslavpejic85 avatar miroslavpejic85 commented on July 4, 2024

Yes, you shouldn't give the role of host to a random one. Though, let's say I'm in a meeting (as host) and connected to 3 other peers, and the room is unlocked (default). Then I disconnect due to internet issues... thus there is no host and the room is unlocked. Which could lead to someone else joins the meeting (ex. peer name: Joe) which may be a security issue because nobody can control him (Joe).

A ok, got it, I will think about how to solve this behavior. Thank you!

from mirotalk.

miroslavpejic85 avatar miroslavpejic85 commented on July 4, 2024

Hello @professionalNoob123,

It should be fixed now.

Test:

  1. Join room with 4 different peers, username (User-1, User-2, User-3, User-4)
  2. The User-1 is the presenter
  3. Exit room or disconnect due to internet issues the User-1
  4. Join again with User-1 and you can see its again presenter.

Note The presenter (host) is identified by:

  • peer_ip (Public IPv4)
  • peer_name (Your name on join room)
  • peer_uuid (UUID4 autogenerated and stored on browser localStorage)

from mirotalk.

miroslavpejic85 avatar miroslavpejic85 commented on July 4, 2024

Note As Public IPv4 can changes randomly if someone use a VPN, the presenter is now matched by:

  • peer_name (Your name on join room)
  • peer_uuid (UUID4 autogenerated and stored on browser localStorage)

from mirotalk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.