error: illegal IP address string passed to inet_pton

[miserlou]

error: illegal IP address string passed to inet_pton

[Miserlou]

AF_INET6 - looks like easy-timezones isn't IPv6 ready yet! :( :( :(

[lucas03]

Thanks for reply, will it be available? Or could you ignore ipv6 in easy-timezones?

[Miserlou]

Pull requests welcome :)

On Tue, Oct 28, 2014 at 3:21 PM, Lukas Vojt [email protected]
wrote:

Reopened #6 #6.

—
Reply to this email directly or view it on GitHub
#6 (comment)
.

[lucas03]

I created a pull request, it's my first time working with github (hope it works). Codes are similar to yours. Haven't tested it too much, take a look please.

[jasonm]

@vinitkumar's patch works for me. I was encountering this in the https://github.com/torchbox/wagtail CMS admin panel when previewing a page.

In case anyone is following along at home...

Wagtail's "preview this page" functionality issues a dummy request to compute the previewed content. This presumably passes a fake requestor IP address into the dummy request. The django-easy-timezones library has a piece of middleware installed which attempts to infer a time zone based on geolocating the requestor IP. So, when Wagtail issues the dummy request, the bad IP address causes django-easy-timezone to pass a malformed IP to inet_aton, which blows up.

@vinitkumar's additional well-formedness check will defensively prevent not only IPV6 addresses from causing an issue, but any malformed IP address.

[jasonm]

Looking more closely at easy_timezones.middleware.EazyTimezoneMiddleware.process_request, is it reasonable for it to change:

            if ip != '127.0.0.1':
                # if not local, fetch the timezone from pygeoip
                tz = db.time_zone_by_addr(ip)

to also check for a missing IP:

            if ip and ip != '127.0.0.1':
                # if not local, fetch the timezone from pygeoip
                tz = db.time_zone_by_addr(ip)

?

[jasonm]

There seems to be some prior Django discussion that discourages relying on REMOTE_ADDR: https://www.djangoproject.com/weblog/2009/jul/28/security/#secondary-issue so perhaps the if ip and ip != '127.0.0.1' is the way to go?

[Miserlou]

I like that @jasonm.

PR's graciously accepted - if you're using the IPV6 database, please update the documentation to reflect that as well.

Thanks!

[Miserlou]

The supplied code wasn't totally valid, but I've added a different solution and now it should work. I've also started adding tests.

[lucas03]

Nice! will you push it to pip as well? Will you add IPv6 support with GEOIP file for IPv6?

[Miserlou]

@lucas03 - IPv6 support based on the GeoIPv6 file is available in version 0.6.0, published to pip.

Both of the GeoIP files are now included by default for convenience.