Giter Site home page Giter Site logo

Comments (2)

EtienneLem avatar EtienneLem commented on August 22, 2024 1

I really like what you did with the picker! Thanks for submitting the issue ๐Ÿค˜


Frequently used default

In retrospective: I can see how the defaults choice can be tricky. Would you be in favor of being able to provide the default list instead of using the hardcoded one (the one I re-did)?

Smoother anchor bar transitions

Will look into the PR soon. I like the not-over-the-top-subtle-way you did it. ๐Ÿ‘

Search bar fixed at the top

That has been done on my end too, Iโ€™ll be pushing and closing that issue shortly.

Search bar icon

๐Ÿ‘

Clear search functionality

๐Ÿ‘

Permanent scrollbar

๐Ÿ‘ I do like it. We just need to make sure it looks okay on Windows (if youโ€™re not already on Windows (Iโ€™m not, but have access to)).

Click on preview icon to toggle skin tone picker

Iโ€™m neither for nor against. It can however be useful when you want to just close the tone picker without selecting any.

Prettier .emoji:hover CSS

That one we really wanted to be different than Slack. While EmojiMart is very much inspired by theirs, the goal wasnโ€™t to make an exact copy. That being said it does look pretty nice on OB, but Iโ€™m pretty sure it wouldnโ€™t fit on Missive. I donโ€™t think I would want to force that style for everyone using the lib, but I would gladly accept a PR making it an option via a props ๐Ÿ‘. Would be nice to have a default hardcoded array of HEX colors and allow devs to pass a different array of colors. Someone could only use 2, etc.

Misc CSS cleanups

๐Ÿ‘ All in for cleanups. Vanilla CSS may also start to become a little bit less practical. I wouldnโ€™t mind using SCSS w/ Autoprefixer if need be.

In other news:

Performance updates coming soon ๐Ÿ˜›

from emoji-mart.

JustinDrake avatar JustinDrake commented on August 22, 2024

Awesome, sounds good. I was going to mention performance, and I'm very glad you brought it up!

In terms of icons (for the search icon, as well as clear icon) I have been using font-awesome. What is your source for the icons? Would you be open to using font-awesome throughout? What do you suggest?

from emoji-mart.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.