Feature Request: More Accurate Palette / Custom Palettes

[mister-devel]

Feature Request: More Accurate Palette / Custom Palettes

[rsn8887]

The Gameboy core already supports loading custom palettes, maybe some code could be re-used?

[rsn8887]

Here's another link explaining the colodore palette:
https://www.pepto.de/projects/colorvic/

[rsn8887]

From checking RGB values, it looks like the core currently uses the old, less accurate, PEPTO-PAL palette from here:
https://www.pepto.de/projects/colorvic/2001/

But PEPTO-PAL has been superseded. The same author has since improved his calculations and created the improved, more accurate, COLODORE palette, here:
https://www.pepto.de/projects/colorvic/

[sorgelig]

i can update the palette but i don't see table of values for new colors.

[rsn8887]

Thanks!!!! An option to switch between old Pepto-Pal (currently used) and new Colodore palette might be best, since I think some folks like the old palette very much, even if not as accurate. Or you could just update the palette to the new one.

Updated palette from https://www.pepto.de/projects/colorvic/

hex RGB
00, 00, 00
FF, FF, FF
81, 33, 38
75, CE, C8
8E, 3C, 97
56, AC, 4D
2E, 2C, 9B
ED, F1, 71
8E, 50, 29
55, 38, 00
C4, 6C, 71
4A, 4A, 4A
7B, 7B, 7B
A9, FF, 9F
70, 6D, EB
B2, B2, B2

decimal RGB
0, 0, 0
255, 255, 255
129, 51, 56
117, 206, 200
142, 60, 151
86, 172, 77
46, 44, 155
237, 241, 113
142, 80, 41
85, 56, 0
196, 108, 113
74, 74, 74
123, 123, 123
169, 255, 159
112, 109, 235
178, 178, 178

The old palette currently used by the core is the Pepto-Pal palette from https://www.pepto.de/projects/colorvic/2001/
00 00 00
FF FF FF
68 37 2B
70 A4 B2
6F 3D 86
58 8D 43
35 28 79
B8 C7 6F
6F 4F 25
43 39 00
9A 67 59
44 44 44
6C 6C 6C
9A D2 84
6C 5E B5
95 95 95

[sorgelig]

Yeah, i've used photoshop to get hex values from that colored stripe. Just wanted to know if picture represents originally calculated values not altered in any graphical editor/compressor.

[rsn8887]

Yes AFAIK those are the correct numbers, they also appear in WinVice emulator if you select colodore there.

[rsn8887]

The NES core has what seems to be the most comprehensive palette options. There are several presets to choose from, and also a choice „custom“ which allows a user-defined palette to be loaded. Maybe the code from the NES palette option could be re-used here?

[sorgelig]

As i've said before there is no reason to make a Christmas Tree from all cores. C64 had quite fixed colors and it must be used. If there is a errors, then i'm ready to fix it.

[rsn8887]

The error is that currently, wrong colors are used. For the sake of highest accuracy, colors can simply be updated to latest known correct most accurate colors, which are the ones I listed above from https://www.pepto.de/projects/colorvic/

There's no reason really to stick to outdated colors from https://www.pepto.de/projects/colorvic/2001 which have since been revised with new measurements by that same author himself.

I was just afraid people have gotten used to the "wrong" colors for so long, they might not like an update. That's why I mentioned possibility of a palette choice option.

Sorry for the confusion.

[rsn8887]

I made a PR. Thanks for considering this!

[rsn8887]

Fixed in release 20210117. Thanks!