Giter Site home page Giter Site logo

Comments (2)

wjakob avatar wjakob commented on July 17, 2024

Hi @schunkes,

apologies in the delay responding to your message. That is indeed an omission, and we should properly compute the (complex-valued!) relative OR when a real-valued external IOR is provided. Probably not too much an issue in most cases (air), but potentially problematic when metals are observed under water. A PR would be welcomed, though the important thing will be to retain compatibility with the parameter conventions of Mitsuba 1.

Now that said, we could adopt a new set of parameter names (e.g. int_eta, int_k, and ext_eta) that are documented exclusively and preferred by the plugin if available.

Best,
Wenzel

from mitsuba2.

schunkes avatar schunkes commented on July 17, 2024

Hi @wjakob,

thank you for your answer. At this moment we are not targeting under water scenes as you mentioned them, so I expect I will not have the time to create such a PR. However, should problems with the conductor type plugins block our work, I'll make sure to create a PR for our changes.

Best wishes,
Sebastian

from mitsuba2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.