Comments (3)
iRyusa
commented on September 18, 2024
2
Nice catch I need to update js-beautify too, i'll try to get it fixed
tomorrow
…On Tue, Jun 4, 2024 at 6:52 PM Kyle Suss ***@***.***> wrote:
*Describe the bug*
Some time recently, the output of mjml2html has changed for the lang
attribute on the mjml element. If either an empty string is passed in or
the attribute is not used, the html output looks like this <html
lang="und" which is not a valid value for the attribute. The
default/empty state of lang in html is just an empty string (source
<https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/lang>
).
*To Reproduce*
Here is a simple reproduction using mjml 4.15.3:
https://github.com/kylesuss/mjml-lang/tree/main
In the reproduction, a simple mjml structure is converted to html using
mjml2html and logged to the console where you can see the lang="und"
output.
This doesn't happen on the "try it live" version here:
https://mjml.io/try-it-live
So it seems like the change happened in between 4.9.3 & 4.15.3.
*Expected behavior*
The lang attribute should either be excluded if empty, or use an empty
string to signify that it is empty.
*MJML environment (please complete the following information):*
- OS: MacOS
- MJML Version 4.15.3
- MJML tool used mjml2html
*Screenshots*
CleanShot.2024-06-04.at.10.50.38.png (view on web)
<https://github.com/mjmlio/mjml/assets/3035355/3ee6d12e-394e-4a6d-9e54-667980f92375>
The above code produces this output:
CleanShot.2024-06-04.at.10.50.22.png (view on web)
<https://github.com/mjmlio/mjml/assets/3035355/945f262f-bfb8-4cdd-a9e0-5214c73b66c4>
—
Reply to this email directly, view it on GitHub
<#2865>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAELHTI7UI7VTTR6L5FINHLZFXWF3AVCNFSM6AAAAABIY4Z2I2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZTGOJXGI4TCMY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
from mjml.
iRyusa
commented on September 18, 2024
It seems it was something recommended by https://emailmarkup.org/en/reports/accessibility/2023/ cc @garrettjohnson see #2725
So I'm closing this as it seems good :
(5) Serious: element must have a lang attribute
Issue present in 72.19% (211,915) of emails tested.Number of appearances: 211,915.
Why it’s needed:
Setting a language for the document helps with a range of things from translation tools to tell assistive technology how to correctly read out the content.How to fix this:
Add a lang="" attribute to the element. It’s important to apply the correct language, however if you need fallback for when a language is not set then you can set lang="und", this sets the language as undetermined. It’s not nearly as good as setting a language but it’s much better than setting nothing.
from mjml.
kylesuss
commented on September 18, 2024
@iRyusa thanks for the link -- I couldn't find anything like that when I looked it up. Ok I guess we'll roll with it then!
from mjml.
Related Issues (20)
- how to add a helper container for an image so it can be centered between elements. HOT 1
- Custom mj-head component causes TypeError: this.context.processing is not a function HOT 8
- Outlook 2404 build 17531.20119 not rendering MJML template HOT 10
- MJML Templates not rendering as expected in New Outlook on Windows HOT 4
- Wrong vertical-align in mj-column HOT 1
- Outlook web client doesn't render columns HOT 5
- mjml column is not working in hotmail
- Invalide Certificate HOT 8
- Try it live does not allow pasting HOT 3
- HTML Comments rendered with additional white space HOT 3
- Replace old not maintained Laravel / PHP package HOT 3
- Button rendered without href url on Outlook email HOT 5
- Splitting mjml2html to allow for better use of custom components and templating HOT 1
- installation causing vulnerabilities HOT 1
- Inline external fonts HOT 1
- Handlebars being thrown out in the compiled html in a overridden mjml-column component HOT 2
- Mj-column borders w/ border-radius are not rendering correctly HOT 1
- Possibility to add default <mj-section> background-color HOT 1
- Different outlook browsers rendering differently? HOT 4
- mj-raw component breaks html in multi column layout HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mjml.