Giter Site home page Giter Site logo

Comments (6)

yjx1217 avatar yjx1217 commented on August 23, 2024

hmm, I found out the current version at GitHub (not the released one) does not have this issue. But the "-i" option (for set min_identity cutoff for BLAST) seems not working properly. I set "-i 90" in my command line but the output still shows hits with identity < 90.

from easyfig.

mjsull avatar mjsull commented on August 23, 2024

Hi Jia-Xing,

Yes, someone emailed me about that bug last week, but thanks for letting me
know anyway. I have fixed it on github (as you noticed) but haven't had
time to create the new executables and update the website. I will make sure
I do it tomorrow.

When you say the output still shows hits with identity < 90 do you mean the
image or the BLAST output? The filtering is done by Easyfig after the BLAST
file has been created so that parameters can be adjusted without having to
generate a new BLAST file, so all hits will be in the BLAST output
(regardless of what settings were provided). If they aren't being filtered
in the image please let me know.

Best,

Mitchell

On 20 December 2015 at 16:20, Jia-Xing Yue [email protected] wrote:

hmm, I found out the current version at GitHub (not the released one) does
not have this issue. But the "-i" option (for set min_identity cutoff for
BLAST) seems not working properly. I set "-i 90" in my command line but the
output still shows hits with identity < 90.


Reply to this email directly or view it on GitHub
#2 (comment).

from easyfig.

yjx1217 avatar yjx1217 commented on August 23, 2024

Dear Mitchell,

Thank you very much for the reply. About the BLAST, yes, I think the
filtering doesn't work in the image. I set min_identity cutoff as 90 but
the BLAST identity scale bar in the image still starts from 62 in my case.
So I think there might be something wrong. Also, is it possible to let
Easyfig keep the raw BLAST table result rather than delete it after the
image was generated? If not, could you add this feature in the near future?
I think this will be very helpful in some cases. Thanks again!

Best,
Jia-Xing

On Mon, Dec 21, 2015 at 10:55 PM, mjsull [email protected] wrote:

Hi Jia-Xing,

Yes, someone emailed me about that bug last week, but thanks for letting me
know anyway. I have fixed it on github (as you noticed) but haven't had
time to create the new executables and update the website. I will make sure
I do it tomorrow.

When you say the output still shows hits with identity < 90 do you mean the
image or the BLAST output? The filtering is done by Easyfig after the BLAST
file has been created so that parameters can be adjusted without having to
generate a new BLAST file, so all hits will be in the BLAST output
(regardless of what settings were provided). If they aren't being filtered
in the image please let me know.

Best,

Mitchell

On 20 December 2015 at 16:20, Jia-Xing Yue [email protected]
wrote:

hmm, I found out the current version at GitHub (not the released one)
does
not have this issue. But the "-i" option (for set min_identity cutoff for
BLAST) seems not working properly. I set "-i 90" in my command line but
the
output still shows hits with identity < 90.


Reply to this email directly or view it on GitHub
#2 (comment).


Reply to this email directly or view it on GitHub
#2 (comment).

Jia-Xing Yue

Population Genomics and Complex Traits Group
Tour Pasteur 8eme etage
Faculté de Médecine
Institute for Research on Cancer and Aging, Nice (IRCAN)
CNRS UMR 7284 - INSERM U 1081
Université de Nice Sophia Antipolis
28 Avenue de Valombrose
06107 NICE Cedex 2
France

Lab website: http://ircan.org/index.php?Itemid=98
Personal website: http://www.iamphioxus.org/

from easyfig.

yjx1217 avatar yjx1217 commented on August 23, 2024

Dear Mitchell,

I've just tried the newest version code on github and found this error
still remains. I attached the test data for your check. As you can see that
I've already specified "-i 90" in my command (run_easyfig.sh) but the
resulting plot still shows hits with identity as low as 70% (based on the
scale bar). Could you have more check about this? Thanks in advance!

Best,
Jia-Xing

On Mon, Dec 21, 2015 at 11:04 PM, Jia-Xing Yue [email protected] wrote:

Dear Mitchell,

Thank you very much for the reply. About the BLAST, yes, I think the
filtering doesn't work in the image. I set min_identity cutoff as 90 but
the BLAST identity scale bar in the image still starts from 62 in my case.
So I think there might be something wrong. Also, is it possible to let
Easyfig keep the raw BLAST table result rather than delete it after the
image was generated? If not, could you add this feature in the near future?
I think this will be very helpful in some cases. Thanks again!

Best,
Jia-Xing

On Mon, Dec 21, 2015 at 10:55 PM, mjsull [email protected] wrote:

Hi Jia-Xing,

Yes, someone emailed me about that bug last week, but thanks for letting
me
know anyway. I have fixed it on github (as you noticed) but haven't had
time to create the new executables and update the website. I will make
sure
I do it tomorrow.

When you say the output still shows hits with identity < 90 do you mean
the
image or the BLAST output? The filtering is done by Easyfig after the
BLAST
file has been created so that parameters can be adjusted without having to
generate a new BLAST file, so all hits will be in the BLAST output
(regardless of what settings were provided). If they aren't being filtered
in the image please let me know.

Best,

Mitchell

On 20 December 2015 at 16:20, Jia-Xing Yue [email protected]
wrote:

hmm, I found out the current version at GitHub (not the released one)
does
not have this issue. But the "-i" option (for set min_identity cutoff
for
BLAST) seems not working properly. I set "-i 90" in my command line but
the
output still shows hits with identity < 90.


Reply to this email directly or view it on GitHub
#2 (comment).


Reply to this email directly or view it on GitHub
#2 (comment).

Jia-Xing Yue

Population Genomics and Complex Traits Group
Tour Pasteur 8eme etage
Faculté de Médecine
Institute for Research on Cancer and Aging, Nice (IRCAN)
CNRS UMR 7284 - INSERM U 1081
Université de Nice Sophia Antipolis
28 Avenue de Valombrose
06107 NICE Cedex 2
France

Lab website: http://ircan.org/index.php?Itemid=98
Personal website: http://www.iamphioxus.org/

Jia-Xing Yue

Population Genomics and Complex Traits Group
Tour Pasteur 8eme etage
Faculté de Médecine
Institute for Research on Cancer and Aging, Nice (IRCAN)
CNRS UMR 7284 - INSERM U 1081
Université de Nice Sophia Antipolis
28 Avenue de Valombrose
06107 NICE Cedex 2
France

Lab website: http://ircan.org/index.php?Itemid=98
Personal website: http://www.iamphioxus.org/

from easyfig.

mjsull avatar mjsull commented on August 23, 2024

Hi Jia-Xing,

Should be all fixed now :)

Also if you add the "-keep" flag before your genbank files Easyfig will now keep the temp_easyfig folder with all the blast output in it.

Best,

Mitchell

from easyfig.

yjx1217 avatar yjx1217 commented on August 23, 2024

Hi Mitchell,

Thank you very much for the fix and enhancement!

Best,
Jia-Xing

On Mon, Jan 25, 2016 at 4:52 PM, mjsull [email protected] wrote:

Hi Jia-Xing,

Should be all fixed now :)

Also if you add the "-keep" flag before your genbank files Easyfig will
now keep the temp_easyfig folder with all the blast output in it.

Best,

Mitchell


Reply to this email directly or view it on GitHub
#2 (comment).

Jia-Xing Yue

Population Genomics and Complex Traits Group
Tour Pasteur 8eme etage
Faculté de Médecine
Institute for Research on Cancer and Aging, Nice (IRCAN)
CNRS UMR 7284 - INSERM U 1081
Université de Nice Sophia Antipolis
28 Avenue de Valombrose
06107 NICE Cedex 2
France

Lab website: http://ircan.org/index.php?Itemid=98
Personal website: http://www.iamphioxus.org/

from easyfig.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.