Giter Site home page Giter Site logo

Comments (4)

mkkellogg avatar mkkellogg commented on July 30, 2024 1

I have added a WIP branch that forces the sort to be floating sort based: https://github.com/mkkellogg/GaussianSplats3D/tree/float_sort. By default, the integer-based sorting should be off. Try that out and let me know if it changes anything. If it doesn't, I think maybe my octree might be causing problems.

from gaussiansplats3d.

skia avatar skia commented on July 30, 2024 1

Thank you @mkkellogg !

This works like a charm 😄

To be honest i wasn't sure it was the integer-based sorting because i couldn't figure out why they would disappear - i would have imagined points at the back would come to the front or something similar...

I think integer-based sorting should be on by default - most of the people would use small scenes and as you said it's faster, i think it would attract more people to use this library 😄 .
Then again, in both cases i have solid 60fps using a GTX1070 - so maybe the difference is not noticeable and it's better to be more compatible?

Sorry - i forgot to mention i also changed MaximumDistanceToRender and Camera.Far to 50000!

from gaussiansplats3d.

mkkellogg avatar mkkellogg commented on July 30, 2024

I tried with the file you attached and I cannot see anything, so I'm not sure what the problem is there.

But I think I might know what your original problem is: I currently cheat a bit to boost performance by converting splat centers to integers for the sort. The way I do it makes it possible for integer overflow to occur during the calculation of splat distances from the camera. Integer based calculations are a lot faster than floating point so this resulted in a noticeable improvement in sort time.

This isn't a problem for small scenes, but definitely is for larger scenes. I guess I need to just convert back to a floating point sort.

Would you be able to upload the full scene somewhere so that I can use it for testing?

from gaussiansplats3d.

mkkellogg avatar mkkellogg commented on July 30, 2024

Great, I'm glad that fixed it! I think you're right about leaving the integer-based sort as the default. I think most people will use this for smaller scenes.

from gaussiansplats3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.