Attachment upload does not work in Firefox

[GoogleCodeExporter]

Attachment upload does not work in Firefox

[GoogleCodeExporter]

Firefox on Linux has the same problem.  My tests on Mac and Linux were both 
with version 9.0.1.

With a patch (below) to remove popup.hide() in UploadFormPopup, I can get 
Firefox to send some data to the server, but it seems to be incorrectly 
encoded.  The local dev_appserver runs OOM trying to parse the data Firefox 
sends.

Not investigating any further for now.

diff --git 
a/src/com/google/walkaround/wave/client/attachment/UploadFormPopup.java 
b/src/com/google/walkaround/wave/client/attachment/UploadFormPopup.java
index 063ebcc..8564ecb 100644
--- a/src/com/google/walkaround/wave/client/attachment/UploadFormPopup.java
+++ b/src/com/google/walkaround/wave/client/attachment/UploadFormPopup.java
@@ -27,6 +27,7 @@ import com.google.gwt.uibinder.client.UiBinder;
 import com.google.gwt.uibinder.client.UiField;
 import com.google.gwt.uibinder.client.UiHandler;
 import com.google.gwt.user.client.Event;
+import com.google.gwt.user.client.ui.Button;
 import com.google.gwt.user.client.ui.FileUpload;
 import com.google.gwt.user.client.ui.FormPanel;
 import com.google.gwt.user.client.ui.SubmitButton;
@@ -93,6 +94,8 @@ public final class UploadFormPopup {
   FileUpload file;
   @UiField
   SubmitButton submit;
+  @UiField
+  Button cancel;

   private final IFrameElement iframe;
   private final HandlerReference onloadRegistration;
@@ -147,7 +150,7 @@ public final class UploadFormPopup {
   private void destroy() {
     onloadRegistration.unregister();
     popup.hide();
-    iframe.removeFromParent();
+    //iframe.removeFromParent();
     stage = Stage.END;
     log.log(Level.INFO, "end");
   }
@@ -230,12 +233,12 @@ public final class UploadFormPopup {
   @UiHandler("submit")
   void handleSubmit(ClickEvent e) {
     Preconditions.checkState(stage == Stage.HAVE_TOKEN);
-    // The browser's default action can not be relied upon to submit the form,
-    // because this handler is removing the form from the DOM, so a manual
-    // submit is required (before hiding the popup).
     e.stopPropagation();
     form.submit();
-    popup.hide();
+    //popup.hide();
+    submit.setEnabled(false);
+    file.setEnabled(false);
+    cancel.setEnabled(false);
     stage = Stage.UPLOADING_FILE;
     log.log(Level.INFO, "posting file");
     if (listener != null) {

Original comment by [email protected] on 15 Jan 2012 at 7:11

• Changed title: Attachment upload does not work in Firefox