Finding a text in the page

[mlajtos]

Finding a text in the page

[michalklempa]

May I suggest some key binding to 'jump to next search result' and 'jump to previous?', what are the usual bindings on these (not n and N as in less :D)

[marc2332]

I am working on this in https://github.com/marc2332/mosaic.

So far:

• Ctrl+F opens a floating search box ( that's my design, it can be obviously discussed)
• Esc closes it
• The floating box has a input where you can write and a button to close next to it

Result:

Ideas:

• Add an option to search Up/Down
• Add an option to toggle case sensitive

Note: I have never used recoil, but I am trying my best 👍🏻

[marc2332]

Yep!

In Firefox these shortcuts are (pretty bad in my opinion):
Ctrl+G -> Next result
Shift F3 -> Previous result

I would definitely use ones more friendly, specially for the 'previous' one. And also add some Up and Down arrows to do the same

[mlajtos]

Hey @marc2332,

I tried your Find in Page implementation and it works quite okay. Go ahead and make a PR.

Don't worry about Recoil.js, I jumped on it because I wanted to try out something new, so we are in the same boat being beginners. 🙂 So far I can see it has shortcomings (especially for this project 😅), but I hope they will be worked out as we go further.

About keybindings – I use Enter for next and Shift-Enter for previous. These only makes sense. At least for me.

Btw nice touch adding animation. 🙂

[marc2332]

The PR is #12 Feel free to review it ^^

[mlajtos]

Fixed by #14