Giter Site home page Giter Site logo

Comments (3)

blaiszik avatar blaiszik commented on August 15, 2024

Each notebook has logic as below

try:
    import google.colab
    no_local_server = True
    no_browser = True
    globus = False
except: # when not in google colab
    no_local_server = False
    no_browser = False
    globus = True

This combines the logic for choosing the auth path with choosing the download path. I think we should set globus=False in both cases by default, and have a commented out globus=True path that explains what it does. e.g., as below

try:
    import google.colab
    no_local_server = True
    no_browser = True
    globus = False
except: # when not in google colab
    no_local_server = False
    no_browser = False
    globus = False


# If you would like to use Globus to download the data, ensure you have an endpoint running, and uncomment the following line
# globus = True

from foundry.

kjschmidt913 avatar kjschmidt913 commented on August 15, 2024

Looking at the larger picture, should we default to globus=False if the user doesn't pass in a globus parameter when initializing? Would that simplify things?

from foundry.

blaiszik avatar blaiszik commented on August 15, 2024

globus=False is the default now. That's actually what caused the breaking change. Since we pass globus variable to all the class inits in the notebook, I think setting it here explicitly is a shorter path than updating everywhere.

from foundry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.