Giter Site home page Giter Site logo

Comments (6)

pat-s avatar pat-s commented on July 17, 2024

@be-marc This got a few questions during the last workshop. I wonder if we should handle this internally?
I can't remember if something was preventing is from doing so?

from mlr3spatial.

be-marc avatar be-marc commented on July 17, 2024

No, not technically. I'm not sure to what degree we should hide things from the user.

from mlr3spatial.

pat-s avatar pat-s commented on July 17, 2024

Think of the average (spatial) modeling user: the user is doing a prediction and then sees the use of as_unsupervised_task() and thinks: "wait, what does this do now and why is it needed?". The point is that usually people rarely use unsupervised tasks and there is no other occurrence AFAICS where this is needed to execute a prediction scenario.

It then happened that I had to explain this (or I rather said: "well, there are technical reasons why we need to do so but you don't need to worry" because there is no time in a presentation to go deeper into this and it might confuse people even (more) at this point).

I think it might be better if

  • we allow passing the raster directly
  • document the use of of the unsupervised task in the help page of predict_spatial()

In the end users want to predict on a raster and they don't really care if this one needs to be wrapped into an unsupervised task, mainly because for internal mlr3 reasons.

What do you think?

from mlr3spatial.

be-marc avatar be-marc commented on July 17, 2024

I think this only works if the user is not making a mistake. For example, if the user passes a raster to predict_spatial() with a missing spectral band. He will get an error from the learner that TaskUnsupervised misses a feature. The user did not create a TaskUnsupervised so this might be confusing.

We often pass a task to a learner for making predictions. It's one of the first things the user learns in the book. I think the API is fine like this.

from mlr3spatial.

be-marc avatar be-marc commented on July 17, 2024

It then happened that I had to explain this (or I rather said: "well, there are technical reasons why we need to do so but you don't need to worry" because there is no time in a presentation to go deeper into this and it might confuse people even (more) at this point).

We could just say that in mlr3 predictions are usually made on tasks.

from mlr3spatial.

be-marc avatar be-marc commented on July 17, 2024

I changed my mind. Passing spatial objects is now supported. TaskUnsupervised still works but will be removed from the docs.

#82

from mlr3spatial.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.