Comments (9)
Thanks for reporting. I'm taking a look and eventually could create a 2.16.1 to fix the issue
from little-cms.
The stride needs to be corrected like in the other, similar functions: Stride /= PixelSize(info->OutputFormat);
.
I see it's already fixed in master. Thank you.
from little-cms.
Should I create a 2.16.1? I realize that could be a stopper for your package. Just let me know.
from little-cms.
Not really a showstopper for me. I can build against a patched version of lcms2 if necessary. On the other hand, known access violations might pose a security risk so it's probably a good idea to release the fix soonish.
from little-cms.
Are there any known limitations using half floats (float16) in lcms? I get some crashes during the imagecodecs tests when enabling half floats. Is that worth investigating and opening another issue?
from little-cms.
This fixes the segfaults with float16 formats for me:
diff --git a/src/cmspack.c b/src/cmspack.c
index c191896..a594a3d 100644
--- a/src/cmspack.c
+++ b/src/cmspack.c
@@ -3426,7 +3428,7 @@ cmsUInt8Number* UnrollHalfToFloat(_cmsTRANSFORM* info,
cmsUInt32Number i, start = 0;
cmsFloat32Number maximum = IsInkSpace(info ->InputFormat) ? 100.0F : 1.0F;
- Stride /= PixelSize(info->OutputFormat);
+ Stride /= PixelSize(info->InputFormat);
if (ExtraFirst)
start = Extra;
from little-cms.
Are there any known limitations using half floats (float16) in lcms?
All transforms seem to work now from/to half float, except output to planar half float, which fails with "Unsupported raster format".
from little-cms.
This fixes the segfaults with float16 formats for me:
That is a bug, thanks for finding it.
I'm fixing it in e88056e
from little-cms.
All transforms seem to work now from/to half float, except output to planar half float, which fails with "Unsupported raster format".
yes, that's not implemented.
from little-cms.
Related Issues (20)
- It8 get wrong strings when SAMPLE_NAME start with number.
- Postscript creation code sometimes unusable HOT 2
- UBSan errors found in cmsGetColorSpace: not a valid value for type 'cmsColorSpaceSignature' HOT 2
- [question] How hard it might be to support OpenCL? HOT 1
- Request: allow the provided GPL plugins to build by default HOT 2
- version mismatch in some files HOT 1
- 2.16: meson falis HOT 6
- Simple Question: How do I get "cmsICCMeasurementConditions" data in IccProfile? HOT 2
- Eval4Inputs optimisation HOT 5
- CI: use a dependency update tool to keep GitHub Actions updated
- website blog doesn't announce 2.16 release HOT 1
- Backwards incompatible API-change in 2.16 HOT 5
- The fast float plugin doesn't premultiply alpha HOT 1
- Plugins lack soversion when configured with meson
- Possible NPD in cmsCreate_OkLabProfile HOT 2
- FTBFS since commit c429e37 wrt type checking on pointer types HOT 2
- ICC profile with CICP tag HOT 14
- Unable to find program in file system after install HOT 4
- Overflow checks in cmsCreateExtendedTransform HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from little-cms.