Comments (7)
In case anyone else sees this, for reference, I made this change in my fork here.
from typist.pk3.
@mmaulwurff was there a specific reason you can recall that necessitated downcasing all letters in custom word lists/lessons?
from typist.pk3.
I don't remember why I did this. Possible reasons:
- lesson difficulty: for faster typing.
- performance: for shorter word lists.
from typist.pk3.
Would you consider either:
- loosening the behavior so that there's no unexpected limitations on custom lessons (I say unexpected because I had to go look at the code to see why my word lists weren't being displayed as-is)?
- allowing parameters like whether capital letters can be used or not, and min/max word length, to be configurable in the Typist UI menus?
If you think that these suggestions aren't appropriate for your project, that's okay! I'd be happy to just continue tweaking my fork where I can :)
from typist.pk3.
I think removing all the limitations is the best idea. Letter case, allowed characters, word length - let it be decided by the text itself.
Now I remember - the idea behind custom lesson was to allow the user throw any text at Typist and it would just work. That idea proved to be not feasible, as some preparation and manual filtering was always needed.
from typist.pk3.
So, if I understand your comment, you'd be in favor of getting rid of the filterLetters(contents)
and filterWords(words, result._wordSet)
functions altogether, but that wasn't possible due to some filtering always being needed. In that case, would you support at least loosening the filters in some ways, like allowing capital letters and/or allowing short(er)/long(er) words? Or, are those conditions the ones that you mentioned you always needed?
If those specific filters need to be there for some reason, then I respect that, and I'm happy to close this issue. I'm planning to keep the altered conditions in my fork, though, but are there any landmines I should watch out for by keeping them in?
from typist.pk3.
I may have not expressed myself clearly. I'd be in favor of getting rid of filter functions altogether, and I see no disadvantages of that.
Initially, I wanted to accept all kinds of text - like, full stories. Hence the filters - to extract words from the text. But then I found out that the best way to use custom lessons is with simple word lists.
from typist.pk3.
Related Issues (20)
- add an option to fire by any letter, without confirmation
- add a slider for enemy damage
- assign points only when enemies are killed in Combat mode
- add an option to switch to combat mode by firing
- Incompatible with No UltraViolence mod; current map closes upon trying to fire at enemies about 75% of the time HOT 1
- add command to use objects HOT 1
- Toggle automap off upon encountering an enemy HOT 1
- Adding support for compilation on macOS
- Add an option to disable friendly fire between enemies
- Add an option to disable killing multiple enemies with a single shot, regardless of weapon
- Automatically turn off automap when Combat Mode engaged
- Switch to Exploration Mode upon death
- add basic instructions to the start screen
- don't count allies from Paranoid as enemies
- add on-screen keyboard
- add an option for longer words for bigger enemies
- change dash commands to WASD by default
- make exit combat mode key configurable
- investigate Paranoid headcrabs - not hittable with a crowbar
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typist.pk3.