KNP Breadcrumb annotation

[mmoreram]

KNP Breadcrumb annotation

[ErikTrapman]

I use KNP instead of PagerFanta (just a habit, no real reason) and i would be happy with KNP support. It would mean your listAction would look like this:

public function indexAction(PaginationInterface $paginator)

and the PaginatorAnnotationResolver would look sth like this:

public function decidePaginatorFormat(
        Paginator $paginator,
        $parameterType,
        $limitPerPage,
        $page
    ) {
        if ('Pagerfanta\Pagerfanta' === $parameterType) {
            $paginator = new Pagerfanta(new DoctrineORMAdapter($paginator->getQuery()));
            $paginator->setMaxPerPage($limitPerPage);
            $paginator->setCurrentPage($page);
        }
        if('Knp\Component\Pager\Pagination\PaginationInterface' === $parameterType){
            $knp = new \Knp\Component\Pager\Paginator();
            $paginator = $knp->paginate($paginator->getQuery(), $page, $limitPerPage);
        }
        return $paginator;
    }

Would that be feasible? And would that help you in using KNP-breadcrumbs?

[jcornide]

@ErikTrapman to create codeblocks: https://guides.github.com/features/mastering-markdown/ look for 'php'

[ErikTrapman]

Got it. Thnx.

[ErikTrapman]

@mmoreram any thoughts on this?

[mmoreram]

@ErikTrapman Oh... yes! Why not! :)

[mmoreram]

@ErikTrapman Could you please PR it with tests? :) And ping me as soon is ready! ^^

[ErikTrapman]

lol.
Sure, i'll see what i can do, will probably be next week though.

@ErikTrapman have you done it? :)

[ErikTrapman]

@JHGitty yes of course, it's right here: #84
But tests fail on HHVM due to a bug that's already been fixed, but the Travis environment that does the test is still tripping over it. Maybe @mmoreram can give it another try? If it still fails i'll mark the test skipped.

@ErikTrapman The bug has been fixed for HHVM >= 3.8.0. The travis test runned with HHVM version 3.5.0. That is the reason.