Giter Site home page Giter Site logo

Comments (5)

bartektelec avatar bartektelec commented on August 15, 2024

I think you could combine D.get with F.equals if you really need to. Personally I try to keep it as simple as possible and just write the cb functions like in the example you provided, but there are cases where D.get makes sense - it returns an Option so in case your object (dict) for some reason doesn't have the property in runtime then you can add some additional logic to handle the None option.

Doing the unsafe get is just more code and doesn't bring you any benefits that I know of

pipe(
	collection,
	A.filter(
		flow(
			D.getUnsafe('key'),
			F.equals('value')
		)
	),
	A.reject(
		d => d.id === 0
	),
)

from ts-belt.

tibotiber avatar tibotiber commented on August 15, 2024

Yeah, it is way easier to write the callback. Would there be any value in having something like propEq in your opinion?

from ts-belt.

bartektelec avatar bartektelec commented on August 15, 2024

I'm not sure if by testing you meant writing tests, but Jest and Vitest have a matcher for it toHaveProperty.

Personally I find very little value in grabbing properties by a string, because it only works at root level of the object and if I want to grab a nested value I will again use a predicate.
Maybe there is something that I am missing

from ts-belt.

tibotiber avatar tibotiber commented on August 15, 2024

Ok, thanks. Feel free to close this.

from ts-belt.

JUSTIVE avatar JUSTIVE commented on August 15, 2024

for the code above, our team uses like

pipe(
  collection,
  A.filter(({key})=>key === 'value' ),
  A.reject(({id})=>id === 0)
)

In my opinion, sometimes, using just pure js' operator gives more readability, since pipe and flows add more unnecessary depth to the code. (hope the pipeline operator comes to the js)

from ts-belt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.