Comments (4)
here is my implementation: Visgean/facebook-sdk@f8f05f9
from facebook-sdk.
This is a positive change, but will break Python 2.5 support. I do not think very many people are still using 2.5, though.
from facebook-sdk.
http://stackoverflow.com/questions/2084782/timeout-for-urllib2-urlopen-in-pre-python-2-6-versions here I can see that there is another solution, it might be better to have this in init:
def __init__(self, access_token=None, timeout=1):
self.access_token = access_token
socket.setdefaulttimeout(timeout)
the question is what should be the default timeout - I have look to my facebook insights and average FQL takes about 84ms to process... but of course that is only time on their servers.. And it does not brake the <2.6 compatibility
from facebook-sdk.
Maybe something like:
def __init__(self, access_token=None, timeout=None):
self.access_token = access_token
self.timeout = timeout
# Extraneous code redacted...
def request(self, path, args=None, post_args=None):
# Extraneous code redacted...
try:
file = urllib2.urlopen("https://graph.facebook.com/" + path + "?" +
urllib.urlencode(args), post_data, timeout=self.timeout)
except TypeError:
# We are running in Python 2
if self.timeout:
socket.setdefaulttimeout(self.timeout)
urllib2.urlopen("https://graph.facebook.com/" + path + "?" +
urllib.urlencode(args), post_data)
This would only allow to not have a timeout if they did not want to, would only set the default socket timeout if we are running in Python 2 and a timeout has been set (which is important because it can break other applications), and not break backwards compatibility for people currently using the application.
@Visgean, if you submit a pull request with these changes, I will approve it and roll out a new version to PyPi.
from facebook-sdk.
Related Issues (20)
- Release 4.0.0 to support after deprecation on 7/26/2020 HOT 5
- the package version is too old HOT 1
- How to get photo and message of a specific post via URL HOT 1
- get all connections support time-based pagination HOT 1
- Release support for Graph API version 8.0 HOT 2
- Why it's no v.8, but still 3.1.0 that is deprecated? HOT 3
- login-facebook HOT 1
- Replace the image of a facebook post
- Facebook graph
- [FEATURE REQUEST] Type hinting
- [Bug] Remove support for deprecated Graph API Version "3.1". HOT 3
- how we can post an image with caption to group or page i need help
- JSONDecodeError raised when trying to use put_object method HOT 1
- Update supported versions HOT 4
- H
- How can i put love react on post facebook API
- Hihu HOT 1
- Unable to fetch more than 25 comments
- Could I please receive all notifications and messages for this email
- Any New Release ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from facebook-sdk.