Giter Site home page Giter Site logo

Comments (9)

Rashidium avatar Rashidium commented on July 28, 2024

please mention the version you are using

from countrypicker.

Rashidium avatar Rashidium commented on July 28, 2024

this should be fixed on the latest version 1.0.4

from countrypicker.

emoonadev avatar emoonadev commented on July 28, 2024

Not fixed on 1.0.4

from countrypicker.

Rashidium avatar Rashidium commented on July 28, 2024

would you please describe how the scenario is? i would appreciate if you can specify what's the ui framework used, swiftui or uikit?

from countrypicker.

emoonadev avatar emoonadev commented on July 28, 2024

I use UIKIT, when I start seach for "unit" and select united state the crash occur
See below gif (After clicked on the cell the app crash). I opened pull request that fix this crash
ezgif-3-66ab79c1a7

from countrypicker.

Rashidium avatar Rashidium commented on July 28, 2024

interesting. i was sure fixed it with 1.0.4. let me check and get you back.

from countrypicker.

Rashidium avatar Rashidium commented on July 28, 2024

hello @emoonadev . I've checked in the sample app of 1.0.4 and I couldn't reproduce the crash. Can you double check whether your version is 1.0.4? You can see the version you're using in file inspector of the xcode where SPM package versions are visible. It should contain CountryPicker (1.0.4).

from countrypicker.

emoonadev avatar emoonadev commented on July 28, 2024

Yes the version is 1.0.4

from countrypicker.

Rashidium avatar Rashidium commented on July 28, 2024

Yes I could reproduce it. It's strange that on dismiss ui text field updates suggestion. I thought this is only behavior of UITextField.onEditingChanged. But somehow its same for shouldChangeCharactersIn.
I'm merging your PR with tag 1.0.5. Thanks for contribution @emoonadev 🍻

from countrypicker.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.