Comments (9)
please mention the version you are using
from countrypicker.
this should be fixed on the latest version 1.0.4
from countrypicker.
Not fixed on 1.0.4
from countrypicker.
would you please describe how the scenario is? i would appreciate if you can specify what's the ui framework used, swiftui or uikit?
from countrypicker.
I use UIKIT, when I start seach for "unit" and select united state the crash occur
See below gif (After clicked on the cell the app crash). I opened pull request that fix this crash
from countrypicker.
interesting. i was sure fixed it with 1.0.4. let me check and get you back.
from countrypicker.
hello @emoonadev . I've checked in the sample app of 1.0.4 and I couldn't reproduce the crash. Can you double check whether your version is 1.0.4? You can see the version you're using in file inspector of the xcode where SPM package versions are visible. It should contain CountryPicker (1.0.4).
from countrypicker.
Yes the version is 1.0.4
from countrypicker.
Yes I could reproduce it. It's strange that on dismiss ui text field updates suggestion. I thought this is only behavior of UITextField.onEditingChanged. But somehow its same for shouldChangeCharactersIn
.
I'm merging your PR with tag 1.0.5. Thanks for contribution @emoonadev 🍻
from countrypicker.
Related Issues (12)
- UIViewRepresentable
- Example of UIViewControllerRepresentable HOT 3
- 'getCountries' is inaccessible due to 'internal' protection level HOT 7
- region-code only country initializer HOT 2
- Lisence HOT 1
- poping to the root HOT 1
- Index out of range when I select country from search result HOT 2
- Hide Phone numbers HOT 1
- Adding package failing HOT 1
- Feature Request: Multiple 'selectedCountry' HOT 1
- Improve filter function
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from countrypicker.