CI: local-bridge does not rebuild on new commit

[Thegaram]

CI: local-bridge does not rebuild on new commit

[talex5]

It used to work, but maybe something changed. Maybe it's the same read-only :ro problem as before?

When it's working correctly, you should see https://github.com/moby/datakit/blob/master/bridge/local/sync.ml#L26 logging a message when something changes, followed by https://github.com/moby/datakit/blob/master/bridge/local/sync.ml#L38.

That will wake https://github.com/moby/datakit/blob/master/bridge/local/sync.ml#L105 and you should see https://github.com/moby/datakit/blob/master/bridge/local/sync.ml#L81. You should then see a new commit appear in the DataKit Git repository with the new head. The CI monitors this and should rebuild.

If on_change isn't being called, maybe something went wrong setting up the watch at https://github.com/moby/datakit/blob/master/bridge/local/sync.ml#L48.

[Thegaram]

I tried again with local-bridge compiled and run directly (without docker) and it works this way. It seems to be a docker related issue, my container was not picking up the changes from the mounted volumes. This might be related.

[Thegaram]

Okay it seems like docker does in fact correctly mount volumes. I created a simple container:

FROM alpine:3.5
ENTRYPOINT ["watch", "-n1", "tail /data/.git/logs/refs/heads/master"]

And then ran it, mounting my git repo:

$ docker build -t testvolume -f MyDockerfile .
$ docker run -it --rm -v /path/to/my/repo:/data:ro testvolume

And it correctly picked up any new commit messages. @talex5 do you have any ideas why picking up changes works natively (Mac) but does not work in a container for the local bridge?

Command to run natively:

$ ./main.exe --metadata-store tcp:127.0.0.1:5640 -v me/myproject:/path/to/my/repo

Command to run in a container:

$ docker run -it --rm --network host -v /path/to/my/repo/.git:/data/repos/myproject/.git datakit/local-bridge --metadata-store tcp:127.0.0.1:5640 -v me/myproject:/data/repos/myproject