RETURNS_DEEP_STUBS automatically tries to create serializable mocks

[mockito]

RETURNS_DEEP_STUBS automatically tries to create serializable mocks

[mockitoguy]

Hey,

Perhaps Mockito is too aggressive with this validation. The thing is that this code could break if you stub some of those methods. @bric3, thoughts?

Thanks for reporting! Can you update your code and add Serializable / default constructor?

[bric3]

I just experienced the same issue when I wanted to test our custom DSL API on my current project. I believe there was some issue sometime ago before we moved to github about serialization, it may relate to deep stubs.

https://code.google.com/p/mockito/issues/detail?id=399 right?

I don't really understand this validation - if I have no interest in my code being serializable nor serializing a mock/stub; why do I have to make it so (and add default constructors, allowing partially constructed objects) just to use deep stubs? Shouldn't I have to opt-in if I need/want my deep stubs to be serializable or am I missing something?

[joerg-pfruender-hp]

@szczepiq Hi, for one occurence I was able to implement a default constructor. For another occurence, it did not feel sensible to add a default constructor. I changed this and mocked all used method calls manually. For me it's ok now.
btw: Thank you very much for sharing and caring for mockito!

[bric3]

For some reason the deep stub code was enabling children stubs to be always serializable which doesn't make sense. In the plane I crafted a fix. I'll push it asap.

[bric3]

It should be fixed in 1.10.8

Excellent, thanks @bric3 ! Let me take this chance to add that Mockito is an excellent piece of software and a near-perfect mocking library IMO - all of your efforts are highly appreciated :) I was at a workshop with Michael Feathers recently and was asking him whether he planned to update his book Working Effectively with Legacy Code to reflect the invent of modern (non-strict!) mocking frameworks such as Mockito as in my opinion they have revolutionized dependency-breaking and bringing legacy code under test. No luck, but maybe someone should write a new updated such book :)

[mockitoguy]

Hey,

1.10.8 was released to Bintray/jcenter. For some reason, maven central sync
didn't work :(

What do you think needs to be fixed so that mockito is perfect? :)

On Fri, Oct 10, 2014 at 5:33 AM, Chad [email protected] wrote:

Excellent, thanks @bric3 https://github.com/bric3 ! Let me take this
chance to add that Mockito is an excellent piece of software and a
near-perfect mocking library IMO - all of your efforts are highly
appreciated :) I was at a workshop with Michael Feathers recently and was
asking him whether he planned to update his book Working Effectively with
Legacy Code to reflect the invent of modern (non-strict!) mocking
frameworks such as Mockito as in my opinion they have revolutionized
dependency-breaking and bringing legacy code under test. No luck, but maybe
someone should write a new updated such book :)

Reply to this email directly or view it on GitHub
#99 (comment).

Szczepan Faber
Core dev@gradle; Founder@mockito