Giter Site home page Giter Site logo

Comments (2)

255kb avatar 255kb commented on June 15, 2024 1

Thanks @mauriceackel your fix is indeed working!

from commons-server.

mauriceackel avatar mauriceackel commented on June 15, 2024

The error is this line

The problem is that Array.every returns true if the input array is empty.
Potential fix:

let response = this.routeResponses.find((routeResponse) => {
  if (routeResponse.rules.length === 0) {
    return false;
  }

  return routeResponse.rulesOperator === 'AND'
    ? routeResponse.rules.every(this.isValidRule)
    : routeResponse.rules.some(this.isValidRule);
});

Notice, that I also changed !!routeResponse.rules.find(this.isValidRule) to routeResponse.rules.some(this.isValidRule) and removed the unnecessary double negation at routeResponse.rules.every(this.isValidRule).

@255kb Can you double-checkt that this logic in fact behaves like the current one? Especially w.r.t. the early return/the if statement.

from commons-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.