Comments (5)
Thanks for your feed back.
I think the comma space thing is just a rendering issue (i.e. I thought it looked nicer to have the space between the user names).
The ACL itself does a split on just the comma: https://github.com/jenkinsci/github-oauth-plugin/blob/master/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java#L198
look at line 201 and you will see I trim the parts.
from github-oauth-plugin.
Oh, now I understand.
Still, when I enter p0deje, some_other_user
to Admin User Names, I have admin rights.
But when I enter p0deje,some_other_user
to Admin User Names I loose admin rights and have only READ permissions (just because I enabled Grant READ permissions to all Authenticated Users
Do you have any idea why could this happen?
from github-oauth-plugin.
I think this issue was fixed in the 0.9 plugin release. What version of the plugin are you using?
from github-oauth-plugin.
I use 0.9
from github-oauth-plugin.
I'm no longer maintaining the plugin.
@skottler is but using the main repository here: https://github.com/jenkinsci/github-oauth-plugin
Normally jenkins projects use jira for the issues but I never turned them off here. But I think its confusing for reporters to report here.
I want to turn off the issues on this repository so can you refile the ticket into the jenkins jira for the github-oauth component?
Unfortunately there doesn't seem to be a way to make the existing issues read-only so I can disable issues without all of the existing reported and resolved issues vanishing.
Thanks
from github-oauth-plugin.
Related Issues (20)
- Breaks Jenkins API basic auth HOT 35
- GitHub OAuth Changed HOT 1
- Status Code: 500 when using GitHub Enterprise HOT 3
- auth exception for jnlp access? HOT 2
- Makes Jenkins slow for non-admins HOT 3
- Deprecated github v2 api = no access to Jenkins HOT 35
- 404 errors immediately after implementing HOT 4
- No user at build details ("Started by user ..." empty) HOT 1
- Splitting out OAuth from GitHub API? HOT 4
- 404 for callback URL HOT 1
- New release? HOT 1
- [SUPPORT] Access github auth token from cli or api HOT 4
- Maven build broken?
- wiki references wrong url for new app HOT 1
- NPE when trying access to Jenkins API with auth view github HOT 4
- Breaks Jenkins SSH Server HOT 2
- Issue with github enterprise HOT 2
- HTTP basic auth doesn't work for users != admin HOT 2
- Detach from fork?
- After updating to the latest plugin version, can no longer log in. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-oauth-plugin.