Giter Site home page Giter Site logo

Comments (5)

mocleiri avatar mocleiri commented on June 15, 2024

Thanks for your feed back.

I think the comma space thing is just a rendering issue (i.e. I thought it looked nicer to have the space between the user names).

The ACL itself does a split on just the comma: https://github.com/jenkinsci/github-oauth-plugin/blob/master/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java#L198

look at line 201 and you will see I trim the parts.

from github-oauth-plugin.

p0deje avatar p0deje commented on June 15, 2024

Oh, now I understand.

Still, when I enter p0deje, some_other_user to Admin User Names, I have admin rights.
But when I enter p0deje,some_other_user to Admin User Names I loose admin rights and have only READ permissions (just because I enabled Grant READ permissions to all Authenticated Users

Do you have any idea why could this happen?

from github-oauth-plugin.

mocleiri avatar mocleiri commented on June 15, 2024

I think this issue was fixed in the 0.9 plugin release. What version of the plugin are you using?

from github-oauth-plugin.

p0deje avatar p0deje commented on June 15, 2024

I use 0.9

from github-oauth-plugin.

mocleiri avatar mocleiri commented on June 15, 2024

I'm no longer maintaining the plugin.

@skottler is but using the main repository here: https://github.com/jenkinsci/github-oauth-plugin

Normally jenkins projects use jira for the issues but I never turned them off here. But I think its confusing for reporters to report here.

I want to turn off the issues on this repository so can you refile the ticket into the jenkins jira for the github-oauth component?

Unfortunately there doesn't seem to be a way to make the existing issues read-only so I can disable issues without all of the existing reported and resolved issues vanishing.

Thanks

from github-oauth-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.