Giter Site home page Giter Site logo

Comments (5)

GromNaN avatar GromNaN commented on June 18, 2024

+1

from github-oauth-plugin.

brandonbloom avatar brandonbloom commented on June 18, 2024

I just want to clarify: I think that the current implementation only support read permissions for anonymous users? That is, if this checkbox were to exist, it would be checked and disabled (unclickable). I'm proposing that this checkbox appear and be uncheckable... probably erroring on the side of unchecked by default, instead of the current default.

from github-oauth-plugin.

mocleiri avatar mocleiri commented on June 18, 2024

I tried this in testing and it would break the build tokens, i.e. it would let any request through to invoke the build and ignore the build token.

What is the use case that you need it for?

What I have in the 0.3-SNAPSHOT version is support for the github-plugin webhook (to allow anonymous read) since it already has the checks to validate the request.

I have to solve a serialization issue but hope to have it working soon

from github-oauth-plugin.

brandonbloom avatar brandonbloom commented on June 18, 2024

Honestly, I want to disable anonymous access, except for the github-plugin webhook.

from github-oauth-plugin.

mocleiri avatar mocleiri commented on June 18, 2024

This change is in and contained in the 0.6 release that I just made.

The default is that anonymous read access is disabled but now there is a checkbox incase anonymous reads are ok.

from github-oauth-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.