Giter Site home page Giter Site logo

Comments (4)

asfaltboy avatar asfaltboy commented on August 29, 2024

Hi @sanchig , thank you for your bug report!

In general I'm all in favor of using newest versions of dependencies; however, we need to make sure these newer versions don't break current functionality. Our current requirenetns are:

'django-easy-select2==1.2.5',
'django-braces==1.4.0',
'simplejson>=3.6.5',

Simplejson doesn't seem to be breaking anything, so we could bump and soft freeze >=3.8.2. And django-braces also seems fine.

As for django-easy-select2, version 1.3 removes deprecated Select2TextInput() which is imported in advanced_filters/form_helpers.py. I had a quick look and it seems it can be replaced with the Select2() object but the update of the javascript library select2 to version >4 disables input of user defined choice, and I couldn't find an easy way to enable it back.

As always, PR is appreceiated.

from django-advanced-filters.

asfaltboy avatar asfaltboy commented on August 29, 2024

As reported in issue #34, upgrading (or replacing) django-easy-select is a requirement to add support for Django 1.10.

from django-advanced-filters.

asfaltboy avatar asfaltboy commented on August 29, 2024

Ha, silly me! I grepped the code and we don't even use any functionality of django-easy-select2! This basically means that we can include the js/css manually and remove this dependency entirely!

from django-advanced-filters.

asfaltboy avatar asfaltboy commented on August 29, 2024

PR #36 makes this a non-issue, 1.0.5 will be release shortly

from django-advanced-filters.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.