monochrome graphic display won't compile - vector ?

[lukh]

monochrome graphic display won't compile - vector ?

[salkinium]

BTW: Wanted to share how I like modm, you are all doing an amazing job.

Awwww, thanks!

Some debugging ideas in order:

• Try explicitly constructing the cursor: this->cursor = modm::glcd::Point(0, 0);.
• Could you try compiling with GCC12? We've had other issues with GCC13 before.
• Try before C++23 was enabled (this is the last commit before).
• Finally, the display code was refactored for the 2021q1 release (in #604). Perhaps it was broken since then…

[chris-durand]

#1004 is probably the culprit. The constructor for modm::Matrix is now explicit and previously it worked through some implicit conversions. Apparently, this was not caught by the CI since there is no test for it and the code is not used in any example.
this->cursor = modm::glcd::Point{0, 0}; will likely fix it.

[lukh]

Thanks, I was able to "make it work" by simply revert the matrix related files.
Gonna let it like that for now, and fix it whenever my brain works again ^^

Thanks a lot

[chris-durand]

I can't reproduce the issue with GCC 12. Must be related to GCC 13 then.