size report: no output for custom build dir

[tpraxl]

size report: no output for custom build dir

[tpraxl]

Found it. It's not a bug:

First and foremost: The size module uses configs.size.threshold settings for the folders to inspect. The configs.buildDir seems to be irrelevant for it.

I had a typo (treshold instead of threshold) in my real life project and no configs.size.threshold setting at all in my reduced "project" tests and in the examples to reproduce the issue.

That made the size module fall back to the default values (child folders of build).

So I made the mistake. But it was extremely hard to spot. I needed to debug the code to find that using trial and error.

Makes me wonder if you should add a --debug flag that prints out things like (using default values for config.size.threshold) or (you have unrecognized config values in your yml: …). Not sure though, if this would be worth the effort.

Anyways. At least, the size module should yell when there are configured folders that don't exist.

[grgur]

Thank you for reporting this @tpraxl. I can see opportunities for improving the docs, too. Contributions welcome (hint, hint 😄)

[mitchellsimoens]

FYI, part of #146 was to fix this by changing the default config to use the buildDir. I'll likely release this in a new minor version instead of just a patch but there are some other things that need to be prepped.

[tpraxl]

@mitchellsimoens thanks for the update