Comments (8)
@mogenslund Hey, maybe cross linking issues will get interest in the project! (Only joking.)
from liquid.
Also, doing the same in insert mode breaks things.
from liquid.
I'd be very tempted to rely on a dedicated library for the terminal -- because of all the cases.
This one looks good: https://github.com/mabe02/lanterna
from liquid.
I have commitet a fix for typeaheadapp and commandapp. They have been completely rewritten to use sliders directly, making the code more robust.
I have also made commandapp reuse the typeaheadapp to avoid duplicate code.
Some extensions to typeahead were made to support more usecases.
Next up will be to reuse typeahead app in the findfileapp.
salza.dk/liq.jar has also been updated.
from liquid.
It seems like the bug - at least in one case - is still there: if I start liq.jar, and then press tab, then hold down the up arrow, it corrupts the buffer/slider. Then if I try to work within the app to copy and paste the corrupted slider into a new file, the typeahead also fails.
My immediate reaction is that I would move to using Lanterna for terminal input: their model is like painting into the blocks of the terminal, and they will handle all the input/output details to ensure things aren't corrupted.
In the process of making the editor work with Lanterna, I expect you'll simplify the internals so that Liquid is focused only on the most important Liquid-related things.
Good luck!
from liquid.
If it also happens when you just start Liquid, it does not have anything to do with typeahead. At least I fixed some other problem then :-)
I have not experienced any problems like that when using Terminology, xfce-terminal or xterm. I will try with kitty when I get to a computer with proper opengl support. Maybe it has something to do with raw-mode or supported escape sequences in kitty.
from liquid.
You're right! I tried it in my previous favorite terminal (Terminator) and there's no issue, so I'm guessing, since it works in all the ones you've said and also if I switch to terminal in Ubuntu, that it's probably a bug in Kitty.
So for now I'm actually much more relaxed about Liquid, and I'll probably open a bug report with Kitty!
from liquid.
OK, so it seems like it was a bug that's been fixed in Kitty within the last 25 days!
Like you say, it's good that you were able to refactor some code in this whole process. Now we can move on to more important problems!
from liquid.
Related Issues (20)
- keybinding to swap main and eval window back and forth HOT 1
- JS client
- GraalVM Native Binaries HOT 4
- [question] ijkl or hjkl? HOT 2
- (editor/add-keybinding "dk.salza.liq.keymappings.normal" "f5" editor/kill-buffer) HOT 2
- Slow exit on exceptions HOT 4
- Code formatting? HOT 2
- Improve goto definition
- Evaluate vs evaluate raw keybindings HOT 1
- Improve UX of liq.modes.typeahead-mode in relative mode
- `C-SPC :e<enter>` leaves liquid unusable HOT 3
- Trying to write file in nonexistent directory crashes instead of asking to create directory. HOT 1
- Weird crash when trying to create new line after deleting line HOT 8
- terminal flashing HOT 10
- Japanese Strings don't get colored correctly HOT 8
- Can't assume a "block" cursor HOT 6
- Readability when working on files residing in a very deep directory structure HOT 2
- goto-definition not working 100% HOT 1
- How to implement "fd" cord as <esc> from spacemacs? HOT 2
- Use WINCH signal if available to trigger refresh on terminal resize HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from liquid.