Giter Site home page Giter Site logo

Comments (8)

tom-adsfund avatar tom-adsfund commented on September 28, 2024 1

@mogenslund Hey, maybe cross linking issues will get interest in the project! (Only joking.)

from liquid.

tom-adsfund avatar tom-adsfund commented on September 28, 2024

Also, doing the same in insert mode breaks things.

from liquid.

tom-adsfund avatar tom-adsfund commented on September 28, 2024

I'd be very tempted to rely on a dedicated library for the terminal -- because of all the cases.

This one looks good: https://github.com/mabe02/lanterna

from liquid.

mogenslund avatar mogenslund commented on September 28, 2024

I have commitet a fix for typeaheadapp and commandapp. They have been completely rewritten to use sliders directly, making the code more robust.
I have also made commandapp reuse the typeaheadapp to avoid duplicate code.
Some extensions to typeahead were made to support more usecases.
Next up will be to reuse typeahead app in the findfileapp.
salza.dk/liq.jar has also been updated.

from liquid.

tom-adsfund avatar tom-adsfund commented on September 28, 2024

It seems like the bug - at least in one case - is still there: if I start liq.jar, and then press tab, then hold down the up arrow, it corrupts the buffer/slider. Then if I try to work within the app to copy and paste the corrupted slider into a new file, the typeahead also fails.

My immediate reaction is that I would move to using Lanterna for terminal input: their model is like painting into the blocks of the terminal, and they will handle all the input/output details to ensure things aren't corrupted.

In the process of making the editor work with Lanterna, I expect you'll simplify the internals so that Liquid is focused only on the most important Liquid-related things.

Good luck!

from liquid.

mogenslund avatar mogenslund commented on September 28, 2024

If it also happens when you just start Liquid, it does not have anything to do with typeahead. At least I fixed some other problem then :-)
I have not experienced any problems like that when using Terminology, xfce-terminal or xterm. I will try with kitty when I get to a computer with proper opengl support. Maybe it has something to do with raw-mode or supported escape sequences in kitty.

from liquid.

tom-adsfund avatar tom-adsfund commented on September 28, 2024

You're right! I tried it in my previous favorite terminal (Terminator) and there's no issue, so I'm guessing, since it works in all the ones you've said and also if I switch to terminal in Ubuntu, that it's probably a bug in Kitty.

So for now I'm actually much more relaxed about Liquid, and I'll probably open a bug report with Kitty!

from liquid.

tom-adsfund avatar tom-adsfund commented on September 28, 2024

OK, so it seems like it was a bug that's been fixed in Kitty within the last 25 days!

Like you say, it's good that you were able to refactor some code in this whole process. Now we can move on to more important problems!

from liquid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.