Namespace repeating in Generated.fs

[moiraesoftware]

Namespace repeating in Generated.fs

[7sharp9]

Namespaces should probably be the responsibility of the plugin, although having the namespace in the msbuild file make sit more complex. Any ideas on reconsolidating this?

[7sharp9]

<Compile Include="Generated.fs">
    <MyriadFile>Library.fs</MyriadFile>
    <MyriadNameSpace> DataSchema </MyriadNameSpace>
</Compile>

So you are using something like that but there are 3 nuget plugins?

[TheAngryByrd]

Yeah I have the plugins from https://github.com/MoiraeSoftware/myriad/tree/master/src/Myriad.Plugins and my plugin I'm writing loading.

I'm thinking we can check if parsedInput is empty and not write anything if not.

[TheAngryByrd]

Oh that won't work nevermind.

[TheAngryByrd]

Maybe generators should return a Some/None whether they should write out or not?

[7sharp9]

Im not convinced <MyriadNameSpace> DataSchema </MyriadNameSpace> should exist, but a namespace needs to go somewhere. Also perhaps it should be an attribute of MyriadFile.

Making the plugin return Some/None could be a good move. Maybe prefixing try onto the API.

[7sharp9]

I think MyriadFile is sufficiently generic that it could be any file, not just and F# one, toml would be a good example.

[7sharp9]

The ns generated by plugins could be grouped and merged, problem I worry about is ordering though.

[7sharp9]

p.s. MyriadNameSpace is now obsolete, config based