Plugin loading third party dependencies

[moiraesoftware]

Plugin loading third party dependencies

[7sharp9]

So the plugin is a nuget and its dependencies are not being downloaded?

[TheAngryByrd]

Yeah it's a nuget dependency but my guess is where Myriad is being run, it can't find Newtonsoft.Json. I think this is the same problem F# Analyzers have.

My particular case is I'm running the generator in my test project and just referencing my plugin after build, which doesn't copy all the dependencies.

[7sharp9]

The location of the dll is specified in the .props file:

 <MyriadSdkGenerator Include="$(MSBuildThisFileDirectory)/../lib/netstandard2.1/Myriad.Plugins.dll" />

I wonder if we can do something here...?

[TheAngryByrd]

Yeah so if I do a publish of my plugin and reference that directory with MyriadSdkGenerator it works. Now I'm just wondering how to make this smooth for my testing project.

[TheAngryByrd]

Circling back, doing the recommendation about packaging in F# analyzers works and following the guidlines in the README about testing plugins works smoothly.

[7sharp9]

Ive not read it yet, @Krzysztof-Cieslak Anything you would do different now?

[TheAngryByrd]

Slight correction about making testing work.

I had to add:

    <CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>

to my fsproj. This ensures the build folder contains all the 3rd party dependencies, then loading the plugin via the InTest.props file works.

[Krzysztof-Cieslak]

In Analyzers.SDK we also use McMaster.NETCore.Plugins instead of directly loading stuff with Assembly.Load - as far as I remember this was done to allow a different version of dependencies between plugins and host. Part of the problem in the case of Analyzers.SDK was that we need to stay on netcoreapp2.0.

I think in context of Myriad one thing to explore would be AssemblyDependencyResolver API added in .Net Core 3.1 - https://docs.microsoft.com/en-us/dotnet/api/system.runtime.loader.assemblydependencyresolver?view=netcore-3.1

[7sharp9]

@TheAngryByrd Was this what you meant? ^

[TheAngryByrd]

I did not know that but it's still useful information

[7sharp9]

Did anyone progress this further for a solution as Im hitting something where a version of FCS needs to be loaded and is not found due to a transient ref?

[TheAngryByrd]

I remember doing https://github.com/BinaryDefense/JsonWrapper/blob/master/build.fsx#L565-L620 as a way to put all the dependencies into the nuget package.

[7sharp9]

@TheAngryByrd What if your not doing a pack?

[7sharp9]

Done

[7sharp9]

Maybe we need AssemblyDependencyResolver as things seem to have gone awry with dotnet 6.0. Are you having any issues with your plugins, I forget if you're still maintaining them
/cc @TheAngryByrd @baronfel

[TheAngryByrd]

Sorry, I haven't really touched any of my plugins in years at this point.

[7sharp9]

Stale Bread