Giter Site home page Giter Site logo

Comments (3)

kraih avatar kraih commented on May 27, 2024

I'm afraid this feature request is too imprecise to be considered. What exactly is that command-line "key" supposed to do?

from minion.

Logioniz avatar Logioniz commented on May 27, 2024

I know zero services which need to restart when restart db.

I believe code must look like something like that, but need correctly detect problem of connect to db:

$ git diff
diff --git a/lib/Minion/Command/minion/worker.pm b/lib/Minion/Command/minion/worker.pm
index f85738e..77e1428 100644
--- a/lib/Minion/Command/minion/worker.pm
+++ b/lib/Minion/Command/minion/worker.pm
@@ -22,8 +22,15 @@ sub run {
   my $app = $self->app;
   my $worker = $self->{worker} = $app->minion->worker;
   @$self{qw(register repair)} = (0, 0);
-  eval { $self->_work until $self->{finished} && !keys %{$self->{jobs}}; 1 }
-    or $app->log->fatal("Worker error: $@");
+  until ($self->{finished} && !keys %{$self->{jobs} // {}}) {
+    eval { $self->_work };
+    $app->log->fatal("Worker error: $@") if $@;
+    if ($@ && $@ =~ m/DBI connect/) { # don't know how correctly determine problem connect to db
+      sleep 5;
+    } else {
+      $self->{finished}++;
+    }
+  }
   $worker->unregister;
 }

from minion.

kraih avatar kraih commented on May 27, 2024

I'm open to accepting a good patch for this, but it needs to be well thought out and take all the different backends into account.

from minion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.