Comments (3)
I'm afraid this feature request is too imprecise to be considered. What exactly is that command-line "key" supposed to do?
from minion.
I know zero services which need to restart when restart db.
I believe code must look like something like that, but need correctly detect problem of connect to db:
$ git diff
diff --git a/lib/Minion/Command/minion/worker.pm b/lib/Minion/Command/minion/worker.pm
index f85738e..77e1428 100644
--- a/lib/Minion/Command/minion/worker.pm
+++ b/lib/Minion/Command/minion/worker.pm
@@ -22,8 +22,15 @@ sub run {
my $app = $self->app;
my $worker = $self->{worker} = $app->minion->worker;
@$self{qw(register repair)} = (0, 0);
- eval { $self->_work until $self->{finished} && !keys %{$self->{jobs}}; 1 }
- or $app->log->fatal("Worker error: $@");
+ until ($self->{finished} && !keys %{$self->{jobs} // {}}) {
+ eval { $self->_work };
+ $app->log->fatal("Worker error: $@") if $@;
+ if ($@ && $@ =~ m/DBI connect/) { # don't know how correctly determine problem connect to db
+ sleep 5;
+ } else {
+ $self->{finished}++;
+ }
+ }
$worker->unregister;
}
from minion.
I'm open to accepting a good patch for this, but it needs to be well thought out and take all the different backends into account.
from minion.
Related Issues (20)
- Add a Minion guide HOT 2
- [Feature Request] Add search bar to Minion Admin site HOT 7
- fix typo at Minion::Guide HOT 1
- [Feature Request] ability to filter delayed jobs HOT 1
- Incorrect count for attempts upon ultimate failure? HOT 3
- popper.js not found HOT 2
- [Feature request] allow signals to be sent to workers as well HOT 5
- A Mojolicious app w/ Minion::Backend::Pg always connects to PostgreSQL db on startup HOT 2
- Repair may stuck when many failed jobs HOT 6
- Batch enqueue HOT 2
- linkcheck doesn't work - links never checked HOT 5
- Minion.unlock() concurrency HOT 4
- [Feature Request] Minion Backend list_jobs: using args as search filter HOT 5
- Minion::Admin can not remove retry inactive task HOT 6
- [Feature Request] Allow registering subclass of Minion::Job as task HOT 13
- [Feature Request] Include Test::Minion subclass/role of Test::Mojo HOT 10
- action buttons don't perform their actions, only redirect HOT 2
- Calling `finish`, `note` etc in task code fails on macOS while communicating over TCP HOT 6
- [Feature Request] Finalizier task for locks
- [ Feature request ] An event for progress? HOT 19
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minion.