Giter Site home page Giter Site logo

Comments (5)

kraih avatar kraih commented on May 24, 2024 2

I don't think there are any good reasons why this needs to be part of the Minion Admin UI. It's better to have this feature as a generic 3rd party login plugin on CPAN. The module synopsis already includes a Basic auth example, form login could work just the same.

from minion.

jhthorsen avatar jhthorsen commented on May 24, 2024

I agree with @kraih.

from minion.

srchulo avatar srchulo commented on May 24, 2024

I agree, a third party plugin that already does the login would be good.

The reason I wanted this is that most of my use cases, the login is meant for the users of the site, so it feels a little unnatural to piggyback on that when really what I want is a login just for Minion. So I'm creating a login page/basic login code a few different places for different apps when I use Minion. I thought it could be convenient to have the login page bundled with Minion as a feature for the dashboard.

However, if you both don't think this is a good idea, feel free to close! It's not a ton of code that I have to write, and maybe I could just create something reusable myself, especially if others don't run into this much.

from minion.

jhthorsen avatar jhthorsen commented on May 24, 2024

The problem is that there’s a bunch of ways to handle login, and storing username/passwords in a config file is not a very good idea.

One thing that might be a good idea though, would be if minion provided a login page (html, css), so it would look like minion all the way. That way the user of the plugin could add her/his own action to handle the login credentials.

I’m not sure if that’s a good idea either though, because there might easily come some requests for “I want company logo placeholder” or “I need an email field, not username” or some other features.

from minion.

srchulo avatar srchulo commented on May 24, 2024

The problem is that there’s a bunch of ways to handle login, and storing username/passwords in a config file is not a very good idea.

Yeah, I guess I was just picturing something minimal since that's what I need, but your follow up point is good in that this could launch a bunch of other requests. If that's not the direction of the Admin UI, maybe it would make sense to either do nothing, or do whatever amount is appropriate and make clear in the documentation that Minion did a small amount for consistency, but it's not the direction of Minion to go further down that path.

However, it's always possible there are those who don't read the documentation or don't agree and then generate the requests you mentioned earlier :)

from minion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.