E-Mail not sent when order consists of reduced positions

[mollie]

E-Mail not sent when order consists of reduced positions

[boxblinkracer]

Hi @snc
I wanted to reach out and let you know that the pull request has been merged.
The feature will be released with the next update

[boxblinkracer]

Hi there
thank you for letting us know.
ok that is...just weird...always all these plugins :D

anyway, doing our best to solve it,
thanks

[boxblinkracer]

Hi

I've just tested it, and it worked on my end.
can you output the json error that happens?
what is inside the ordermail variables? might be an invalid json

thank you

[snc]

Hi,

I've continued to debug this issue on our side and found the cause of it. It already fails when encoding the JSON in

Shopware/Subscriber/MailSubscriber.php

Line 167 in 3349a3a

$transaction->setOrdermailVariables(json_encode($variables));

, so the value in the database is NULL.

I've checked json_last_error() and it returned 7 (JSON_ERROR_INF_OR_NAN).
After adding the JSON_PARTIAL_OUTPUT_ON_ERROR flag to the json_encode call it finally worked again:

$transaction->setOrdermailVariables(json_encode($variables, JSON_PARTIAL_OUTPUT_ON_ERROR));

Maybe the plugin could check if the call to json_encode failed, as no exception is thrown by default.

The part of the variables that is causing JSON_ERROR_INF_OR_NAN can be seen here:

...,"price":"15,71","pseudoprice":"20,95","referenceprice":"NaN","has_pseudoprice":true,"price_numeric":15.712499,...

Let's see if I can find out where the referenceprice is set to NaN...

[boxblinkracer]

ah perfect
yes, i would love to improve that in the plugin.
most of the time i try to do the fail-fast approach...otherwise you might not have discovered an invalid price in your json :)

but maybe i can switch over to a softer check and add a json parse log entry instead ;)

what do you think?

[snc]

The following line from the Advanced Promotion Suite plugin is causing the NaN:

$product['additional_details']['referenceprice'] = $price / $purchaseUnit * $referenceUnit;

In our case, the $purchaseUnit and $referenceUnit is null.

I'm unsure about how you should handle NaN and/or Inf case, but you should definitely check if the json_encode result is null. Maybe using serialize and unserialize could be another solution, but this might not be backwards compatible.

[boxblinkracer]

Hi @snc

thank you for this.
i've created an improvement based on your input, worked great for me when producing a NaN value.

values will now be 0, which yeah...could be misleading in case its even displayed in the mail
but still better i think, because the main values should always be valid i think :)

in addition to this, warning logs are generated
let me know what you think

#297

[snc]

Hi @boxblinkracer, the PR looks good to me! Thanks.

[boxblinkracer]

perfect, thanks @snc
always happy to help :)