Giter Site home page Giter Site logo

Comments (1)

gilmoreorless avatar gilmoreorless commented on June 19, 2024

The tests changed because of the following sequence:

  1. When Intl is not available, tz.guess() falls back to checking a range of dates from <current year> - 2 to <current year> + 2. It looks for all zones that match the user's UTC offsets for that date, then chooses the zone with the largest listed population (to make the sorting stable).
  2. Fiji stopped having DST after 2021. This included it in the <current year> - 2 calculation until the end of 2023.
  3. Once the year ticked over to 2024, Fiji suddenly acted the same as a bunch of other Pacific zones without DST for the guess() function.
  4. Since Fiji has a larger population than the other zones, it became the new default guess value, which failed the existing tests.

Given the low frequency of major DST changes like this, and given it's only for the non-Intl fallback, I don't think it's worth trying to change this long term. I've updated the tests in 49fa3a9, and we'll just have to keep an eye on the guess tests at the start of each year.

from moment-timezone.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.