Giter Site home page Giter Site logo

Move package to pure JS about shopify-api-node HOT 7 CLOSED

monei avatar monei commented on May 18, 2024
Move package to pure JS

from shopify-api-node.

Comments (7)

Alua-Kinzhebayeva avatar Alua-Kinzhebayeva commented on May 18, 2024

I agree with CoffeeScript part. I personally don't like it.
I have not been here since the beginning of the module, but I can imagine why people used it. I think they were (and still are) hardworking Rubyists/Full Stacks (and possibly tried to make context switch cheaper) who wanted to have js modules beautiful and consistent.
As for porting completely to JS, I would first finish extend module's functionality, like adding new resources to session object so clients have access to them in their code. Also enabling use of new resources to those who are developing public apps. I know those things are not mutually exclusive and don't have to be sequential, it is my personal choice - functionality first. Mixed style of quotes might not look well, but at the moment I am more concerned with helping people to use the module.

from shopify-api-node.

lpinca avatar lpinca commented on May 18, 2024

I agree with you @Alua-Kinzhebayeva, done is better than perfect, but I also think that clean clode is a feature. A lot of code in this repo is untouchable because it's such a mess.

from shopify-api-node.

Alua-Kinzhebayeva avatar Alua-Kinzhebayeva commented on May 18, 2024

I guess you have an upcoming pr with port to JS. if this is the case, it will be happily merged

from shopify-api-node.

lpinca avatar lpinca commented on May 18, 2024

No, not yet, but maybe in the next few days 😉

from shopify-api-node.

carlosvillu avatar carlosvillu commented on May 18, 2024

The truth is I chose CoffeeScript because, at the time, it was the platform that had more potential to develop the client. None if those reasons hold today, so it makes sense to port to ES6, though I would not only migrate the code but would also review the design,

  • getting rid of the asynchronous API using callbacks
  • using a reactive development style, returning streams in every call
  • favoring composition over inheritance

Sorry I don't have enough time to contribute to the project, but I'm amazed at what it's becoming of it.

from shopify-api-node.

kenrick avatar kenrick commented on May 18, 2024

👍

from shopify-api-node.

lpinca avatar lpinca commented on May 18, 2024

I close this as a significant refactor where CoffeeScript is no longer used, has been completed.
We still don't take full advantage of ES2015 syntax (import, export, destructuring assignment, etc.), but it's a big step forward.

from shopify-api-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.