Comments (3)
Awesome if you would like to look into this. I suggest you fork the repo, do your changes in your version and make a pull request (PR) fixing this issue.
from bsv.
This issue can probably be closed. The sig hashing scheme in BSV is inherited from Bitcoin Cash which itself was based on BIP143. The differences e.g. FORKID, mean that it doesn't make sense to backport a non-BSV sig hashing scheme into the BSV library itself.
For reference:
https://github.com/Bitcoin-ABC/bitcoin-abc/blob/master/doc/abc/replay-protected-sighash.md
https://github.com/bitcoin/bips/blob/master/bip-0143.mediawiki
This issue is related to PR #107 which can be closed too for the same reasons.
from bsv.
This is obsolete for bsv 2.0.
from bsv.
Related Issues (20)
- please add paymail query api HOT 3
- [email protected] Block.toBuffer().toString('hex') not equal to rpc getblock(blockhash, 0) HOT 6
- [email protected] tx.id() not equal to rpc getblock(blockhash, 1) tx id HOT 9
- bsv 3.0 epic checklist HOT 1
- How can I create a transaction with multiple inputs and outputs? HOT 1
- Error in documentation: bsv-private-key.html HOT 1
- version compatible HOT 3
- bsv legacy failing on parse hex script
- Global export of bsv undefined since 2.0.10
- 'testnet' address generation bug? HOT 3
- Increase Block.MAX_BLOCK_SIZE
- bsv version 2 isFullySigned HOT 1
- Tx.fromHex is not equal toHex. See example.
- How to create and send transaction using bsv?
- @Limpisey168
- #1
- #1
- huge memory usage when building a transaction in browser env HOT 1
- BSV Library Version | HD Keys Confussion HOT 3
- [ THIS LIBRARY IS DEPRECATED ] @bsv/sdk Now Available HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bsv.