Giter Site home page Giter Site logo

Comments (3)

mathiasrw avatar mathiasrw commented on August 18, 2024

Awesome if you would like to look into this. I suggest you fork the repo, do your changes in your version and make a pull request (PR) fixing this issue.

from bsv.

bitcartel avatar bitcartel commented on August 18, 2024

This issue can probably be closed. The sig hashing scheme in BSV is inherited from Bitcoin Cash which itself was based on BIP143. The differences e.g. FORKID, mean that it doesn't make sense to backport a non-BSV sig hashing scheme into the BSV library itself.

For reference:
https://github.com/Bitcoin-ABC/bitcoin-abc/blob/master/doc/abc/replay-protected-sighash.md
https://github.com/bitcoin/bips/blob/master/bip-0143.mediawiki

This issue is related to PR #107 which can be closed too for the same reasons.

from bsv.

ryanxcharles avatar ryanxcharles commented on August 18, 2024

This is obsolete for bsv 2.0.

from bsv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.