Comments (14)
How about this version: http://brouken.com/tmp/just-player-no_force_dark.apk ?
from player.
Yeah, this one shows the subtitle correctly with and without dark mode enabled!
But for some reason when I tried enabling caption preferences the subtitle edge color became White again, after seeing this, I changed the edge color to Blue to see if it would show as Pink and... it was Blue! And then, when I put again the Black
edge color, the edge color was correctly Black! lol, maybe this was some sort of cache.
from player.
Works for me. Configure or disable your styling in caption preferences: https://github.com/moneytoo/Player#how-do-i-change-subtitle-font-size-or-color
from player.
Works for me. Configure or disable your styling in caption preferences: https://github.com/moneytoo/Player#how-do-i-change-subtitle-font-size-or-color
Accessibility isn't enabled in my smartphone and the caption preferences also aren't enabled. (Also, looking at your screenshot, looks like it's half working because this first subtitle of the video is supposed to be italic styled, but I guess this isn't related to this issue(?))
By the way, my smartphone is a Xiaomi Mi 9, maybe this information can help somehow.
from player.
Yes, ExoPlayer capabilities for supporting subtitles styling is quite limited. I will check to see if it handles even italic.
Could you try enabling Caption preferences and see if you can override the style?
So in your case the subtitles are white with white outline? I'm using CaptionStyleCompat
to set edgeType
to EDGE_TYPE_OUTLINE
and edgeColor
to BLACK
.
I will try testing it on some older Xiaomi device in a few days.
from player.
Edge Type being Outline
and Edge Color being Black
results in a pure white subtitle, the only thing that looks like I can do is changing the Background Color to Black
, the subtitle becomes readable because now there's a black rectangle behind it.
Screenshot of my caption preferences using Edge Style Outline
:
Screenshot of the player with the above caption preferences:
from player.
Can you try playing any video with captions using NewPipe. It also uses ExoPlayer so we can verify if it's ExoPlayer or device issue and not implementation here.
from player.
Yes, I just did what you asked and saw that NewPipe has the same issue.
from player.
I have few more ideas but I will try test it myself during the weekend and get back to you if I won't be able to proceed without your help.
from player.
Ok! I will be waiting, good luck :D
from player.
It also works fine for me on older Xiaomi Redmi Note 4.
There are however reports of similar issue on newer Xiaomi devices:
- [BUG] Closed captions on mobile won't show character edge style no matter what (reddit)
- Why Youtube Captions don't work properly? (mi.com)
- youtube caption edge not showing (mi.com)
Try this bare test app: https://brouken.com/tmp/test.apk with enabled captions and check if it changes the edge. This sample uses platform VideoView so we know whatever this is ExoPlayer issue or not.
from player.
The test app doesn't show any captions, but the caption edge do work properly on youtube and, as expected, in the default video player.
Edit: Nevermind, the caption wasn't showing because of the language that I had selected, now it shows the caption but, yeah, it also doesn't have the edge color...
Edit 2: I found something really interesting, if I select the "Blue" edge color, the edge color that the video player (and the test app) shows is a pink one! 🤔
Edit 3: Ok, I found the issue, the dark mode of my phone was inverting the edge color, so black was turning white and blue was turning pink... I guess if you could somehow ignore the dark mode in your app this issue could be solved
from player.
Does dark mode trigger the issue in YouTube as well?
from player.
No, I guess because youtube has its own dark mode toggle, changing the dark mode on my phone doesn't affect youtube in any way.
from player.
Related Issues (20)
- Fire stick audio issue
- New feature [zoom in all part of videos] HOT 1
- Translation strings are not updated on Weblate HOT 2
- Feature Request: Simplified APK Generation and Local Installation for 'Player' HOT 1
- "Legacy Lite" version of apk?
- Delayed start up when root folder of videos is set. HOT 1
- Android TV subtitle size setting is ignored, subtitles are always too small. Some setting to override that would be great.
- Add setting of buffer
- Feature request: custom playback speed
- Please support ffmpeg av3a HOT 3
- No subtitles when there are HOT 1
- Low quality content smoothing not working HOT 1
- Adding in app HOT 1
- [Query] Just Player settings HOT 2
- Amazon Fire TV Stick 2nd generation no more AC3 5.1 HOT 1
- MediaCodecAudioRenderer error when playing videos with DD+ on Pixel 7
- Scripting/shaders support — adding new features while keeping the base app simple, and getting the community involved HOT 1
- [Feature Request] Auto select subtitles based on preference.
- Feature Request: Move the controls to the side and do not shade when paused. Sometimes we are trying to study a frame. HOT 1
- Decoder issues HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from player.