Bug: top menu UI has a tough to use layout when search bar is visible on iOS Safari

[Laptop765]

Bug: top menu UI has a tough to use layout when search bar is visible on iOS Safari

[Laptop765]

This is probably related but I can't find a button to add a new contact on iOS Safari.

Edit: I found it rotating to horizontal mode. The Dashboard/Contacts/Vault Settings buttons aren't visible in vertical.

[djaiss]

Alllllright I have to fixed that 😅

[njelich]

@djaiss I've finally managed to get a local setup for the frontend. I can take this one.

[djaiss]

@njelich that's awesome thank you.

[njelich]

It feels like the Paul's Vault vault breadcrum and the options should all go into a hamburger menu, and the search menu grows to fill the remaining space. Is that okay @djaiss ?

[djaiss]

@njelich I agree :-)

[njelich]

It seems there is an implementation of a hamburger style menu in AppLayout.vue. I have some questions regarding the Vue style we should be using.

In Layout.vue the script components are done by doing an export default and then exporting all the props, functions etc as part of an object. In AppLayout.vue the same is done but using the explicit functions such as defineProps and by defining variables as top level vars.

I am assuming the first approach should be used going forwards and everything else should be refactored. Is that right?

[djaiss]

I'm sorry about the quality of the code in general.

During the year we have changed from Vue 2 to Vue 3 and in doing so, we went from export default to the script setup stuff. Personally I don't really like the script setup approach but it's the direction that Vue is taking, so slowly we'll migrate everything to script setup.

[njelich]

I have no complains about code quality, just trying to be consistent and avoid code debt.