Giter Site home page Giter Site logo

SDL Example Crash about cppsharp HOT 5 CLOSED

mono avatar mono commented on May 9, 2024
SDL Example Crash

from cppsharp.

Comments (5)

tomspilman avatar tomspilman commented on May 9, 2024

Hum... it does include:

lib.IgnoreHeadersWithName("SDL_main*");

In the sample. So I suspect that the ignore is not being ignored.... investigating!

from cppsharp.

tomspilman avatar tomspilman commented on May 9, 2024

So the issue seems to be that the overload of CheckTypeReferencesPass.VisitTranslationUnit() does not check TranslationUnit.Ignored.

Does that make sense @tritao?

from cppsharp.

tomspilman avatar tomspilman commented on May 9, 2024

So this is my proposed fix in CheckTypeReferencesPass:

        public override bool VisitTranslationUnit(TranslationUnit unit)
        {
            if (unit.Ignore)
                return false;

            if (unit.IsSystemHeader)
                return false;

            typeRefs = new TypeRefsVisitor();
            return typeRefs.VisitTranslationUnit(unit);
        }

It gets past this error at least.

from cppsharp.

tritao avatar tritao commented on May 9, 2024

Yeah that makes sense. I am not happy about duplicating the checking into each pass but due to how the visitors are done, that seems the most straightforward way to fix it.

from cppsharp.

tomspilman avatar tomspilman commented on May 9, 2024

Cool! I'll submit a PR to fix that then right now!

from cppsharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.